feat(NcRichContenteditable): Allow to pass in an icon URL #3984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
enhancement
5 tasks
| type: String, | ||
| required: true, | ||
| }, | ||
| iconUrl: { |
Contributor
There was a problem hiding this comment.
Since this is the avatar url, I would also call it avatarUrl.
Contributor
Author
There was a problem hiding this comment.
Then it conflicts with the computed and the CSS avatar option is also called icon so I tried to keep it simple and inline
Contributor
There was a problem hiding this comment.
We could come up with something like predefinedUrl, as we provide here a ready-to-download URL
Antreesy
approved these changes
Apr 18, 2023
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Works properly, shouldn't break anything
| type: String, | ||
| required: true, | ||
| }, | ||
| iconUrl: { |
Contributor
There was a problem hiding this comment.
We could come up with something like predefinedUrl, as we provide here a ready-to-download URL
marcoambrosini
approved these changes
Apr 19, 2023
marcoambrosini
deleted the
feat/noid/allow-icon-url-for-autocomplete-results
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.