Migrate from deprecated title prop #4052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
requested review from
Pytal,
ShGKme,
marcoambrosini and
skjnldsv
skjnldsv
approved these changes
May 7, 2023
Pytal
approved these changes
May 8, 2023
Contributor
|
Should we start to make breaking changes list or migration guide? |
Contributor
|
A migration guide similar to the OCP changes sounds like a wunderful idea! |
Closed
1 task
max-nextcloud
added a commit
to nextcloud/collectives
that referenced
this pull request
Nov 9, 2023
2 tasks
mejo-
pushed a commit
to nextcloud/collectives
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since master is
8.0.0now, we can merge all breaking changes scheduled for the next major.This PR removes the
nameTitleFallbackand makes thenameprop required forNcActions*,NcAppNavigationItemandNcBreadcrumb*.