test: Fix test and add CI job

Signed-off-by: Louis Chemineau <louis@chmn.me>

Author: artonge

.github/workflows/node-test.yml

@@ -0,0 +1,112 @@
+# This workflow is provided via the organization template repository
+#
+# https://github.com/nextcloud/.github
+# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
+#
+# SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
+# SPDX-License-Identifier: MIT
+
+name: Node tests
+
+on:
+  pull_request:
+  push:
+    branches:
+      - main
+      - master
+      - stable*
+
+permissions:
+  contents: read
+
+concurrency:
+  group: node-tests-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  changes:
+    runs-on: ubuntu-latest-low
+    permissions:
+      contents: read
+      pull-requests: read
+
+    outputs:
+      src: ${{ steps.changes.outputs.src}}
+
+    steps:
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
+        id: changes
+        continue-on-error: true
+        with:
+          filters: |
+            src:
+              - '.github/workflows/**'
+              - '__tests__/**'
+              - '__mocks__/**'
+              - 'src/**'
+              - 'appinfo/info.xml'
+              - 'package.json'
+              - 'package-lock.json'
+              - 'tsconfig.json'
+              - '**.js'
+              - '**.ts'
+              - '**.vue'
+
+  test:
+    runs-on: ubuntu-latest
+
+    needs: changes
+    if: needs.changes.outputs.src != 'false'
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          persist-credentials: false
+
+      - name: Read package.json node and npm engines version
+        uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
+        id: versions
+        with:
+          fallbackNode: '^20'
+          fallbackNpm: '^10'
+
+      - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
+        uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
+        with:
+          node-version: ${{ steps.versions.outputs.nodeVersion }}
+
+      - name: Set up npm ${{ steps.versions.outputs.npmVersion }}
+        run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
+
+      - name: Install dependencies & build
+        env:
+          CYPRESS_INSTALL_BINARY: 0
+        run: |
+          npm ci
+          npm run build --if-present
+
+      - name: Test
+        run: npm run test --if-present
+
+      - name: Test and process coverage
+        run: npm run test:coverage --if-present
+
+      - name: Collect coverage
+        uses: codecov/codecov-action@0565863a31f2c772f9f0395002a31e3f06189574 # v5.4.0
+        with:
+          files: ./coverage/lcov.info
+
+  summary:
+    permissions:
+      contents: none
+    runs-on: ubuntu-latest-low
+    needs: [changes, test]
+
+    if: always()
+
+    name: test-summary
+
+    steps:
+      - name: Summary status
+        run: if ${{ needs.changes.outputs.src != 'false' && needs.test.result != 'success' }}; then exit 1; fi

src/services/TiledLayout.spec.js

@@ -5,13 +5,6 @@
 
 import { splitItemsInRows } from './TiledLayout.js'
 
-/** @type {import('./TiledLayout.js').TiledItem} */
-const sectionHeader1 = {
-	id: '202204',
-	sectionHeader: true,
-	height: 75,
-}
-
 /** @type {import('./TiledLayout.js').TiledItem} */
 const squareImage1 = {
 	id: 'squareImage1',
@@ -20,13 +13,6 @@ const squareImage1 = {
 	ratio: 200 / 250,
 }
 
-/** @type {import('./TiledLayout.js').TiledItem} */
-const sectionHeader2 = {
-	id: '202205',
-	sectionHeader: true,
-	height: 75,
-}
-
 /** @type {import('./TiledLayout.js').TiledItem} */
 const squareImage2 = {
 	id: 'squareImage2',
@@ -59,33 +45,49 @@ const wideImage1 = {
 	ratio: 10000 / 250,
 }
 
-const items = [sectionHeader1, squareImage1, sectionHeader2, wideImage1, squareImage2, squareImage3, tallImage1]
+const items = [squareImage1, wideImage1, squareImage2, squareImage3, tallImage1]
 
 /** @type {import('./TiledLayout.js').TiledRow[]} */
 const expectedLayout = [
 
 	{
-		items: [sectionHeader1],
-		height: 75,
-		key: '202204',
-	},
-	{
-		items: [squareImage1],
-		height: 220,
+		items: [{
+			...squareImage1,
+			// "* 10" to fit the width
+			width: squareImage1.width * 10, // 2000
+			height: squareImage1.height * 10, // 2500
+		}],
+		height: squareImage1.height * 10, // 2500
 		key: 'squareImage1',
 	},
 	{
-		items: [sectionHeader2],
-		height: 75,
-		key: '202205',
-	},
-	{
-		items: [wideImage1],
-		height: 50,
+		items: [{
+			...wideImage1,
+			// "/ 5" to fit the width
+			width: wideImage1.width / 5, // 2000
+			height: wideImage1.height / 5, // 50
+		}],
+		height: wideImage1.height / 5, // 50
 		key: 'wideImage1',
 	},
 	{
-		items: [squareImage2, squareImage3, tallImage1],
+		items: [
+			{
+				...squareImage2,
+				width: 176,
+				height: 220,
+			},
+			{
+				...squareImage3,
+				width: 176,
+				height: 220,
+			},
+			{
+				...tallImage1,
+				width: 4.4,
+				height: 220,
+			},
+		],
 		height: 220,
 		key: 'squareImage2-squareImage3-tallImage1',
 	},