Skip to content

Commit 67c9374

Browse files
committed
Revert using display name in shared albums' name
+ Improve rendering of cover and header of shared albums Signed-off-by: Louis Chemineau <louis@chmn.me>
1 parent 2aa5818 commit 67c9374

15 files changed

+91
-30
lines changed

β€Ž.gitignoreβ€Ž

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,6 @@ vendor
2222

2323
cypress/videos
2424
cypress/snapshots
25-
cypress/downloads
25+
cypress/downloads
26+
27+
js/*hot-update.*

β€Žcypress/e2e/shared_albums.cy.tsβ€Ž

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,10 +185,8 @@ describe('Manage shared albums', () => {
185185
it('It should display two shared albums', () => {
186186
cy.login(bob)
187187
cy.visit('/apps/photos/sharedalbums')
188-
cy.get('ul.collections__list li')
189-
.contains(`shared_album_test5 (${alice.userId})`)
190-
cy.get('ul.collections__list li')
191-
.contains(`shared_album_test5 (${charlie.userId})`)
188+
cy.get(`[data-test="shared_album_test5 (${alice.userId})"]`).should('have.length', 1)
189+
cy.get(`[data-test="shared_album_test5 (${charlie.userId})"]`).should('have.length', 1)
192190
})
193191
})
194192
})

β€Žjs/photos-main.jsβ€Ž

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žjs/photos-main.js.mapβ€Ž

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žjs/photos-node_modules_vue-material-design-icons_AlertCircle_vue-node_modules_vue-material-design-icons-ea65fb.jsβ€Ž

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žjs/photos-node_modules_vue-material-design-icons_AlertCircle_vue-node_modules_vue-material-design-icons-ea65fb.js.mapβ€Ž

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žjs/photos-public.jsβ€Ž

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žjs/photos-public.js.mapβ€Ž

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žjs/photos-src_views_SharedAlbums_vue.jsβ€Ž

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žjs/photos-src_views_SharedAlbums_vue.js.mapβ€Ž

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
Β (0)