Merge pull request #4538 from nextcloud/backport/4448/stable30

[stable30] feat(test): add tests for template fields with empty labels

Author: juliusknorr

cypress/e2e/templates.spec.js

@@ -126,9 +126,12 @@ describe('Create templates with fields', () => {
 
 	it('Create a document from a template with fields', () => {
 		const fields = [
-			{ type: 'rich-text', alias: 'Name', content: 'Nextcloud' },
-			{ type: 'rich-text', alias: 'Favorite app', content: 'richdocuments' },
-			{ type: 'checkbox', alias: 'Uses Nextcloud at home', checked: true },
+			{ index: 'ContentControls.ByIndex.0', type: 'rich-text', alias: 'Name', content: 'Nextcloud' },
+			{ index: 'ContentControls.ByIndex.1', type: 'rich-text', alias: 'Favorite app', content: 'richdocuments' },
+			{ index: 'ContentControls.ByIndex.2', type: 'checkbox', alias: 'Uses Nextcloud at home', checked: true },
+
+			{ index: 'ContentControls.ByIndex.3', type: 'rich-text', alias: '', content: '' },
+			{ index: 'ContentControls.ByIndex.4', type: 'checkbox', alias: '', checked: false },
 		]
 
 		cy.visit('/apps/files')

cypress/fixtures/templates/document_template_with_fields.odt

@@ -316,19 +316,35 @@ Cypress.Commands.add('submitTemplateFields', (fields) => {
 
 	for (const field of fields) {
 		switch (field.type) {
+
 		case 'rich-text':
-			cy.get('@templateFiller')
-				.find(`input[placeholder="${field.alias}"]`)
-				.type(field.content)
+			if (!field.alias) {
+				cy.get('@templateFiller')
+					.find(`label[for="text-field${field.index}"]`)
+					.should('not.exist')
+			} else {
+				cy.get('@templateFiller')
+					.find(`input[placeholder="${field.alias}"]`)
+					.type(field.content)
+			}
+
 			break
+
 		case 'checkbox':
-			cy.get('@templateFiller')
-				.find('span.checkbox-radio-switch__text').contains(field.alias)
-				.click()
+			if (!field.alias) {
+				cy.get('@templateFiller')
+					.find(`input[id="checkbox-field${field.index}`)
+					.should('not.exist')
+			} else {
+				cy.get('@templateFiller')
+					.find('span.checkbox-radio-switch__text').contains(field.alias)
+					.click()
+			}
+
 			break
+
 		default:
 			expect.fail('Using a field type not yet supported')
-			break
 		}
 	}
 
@@ -354,6 +370,12 @@ Cypress.Commands.add('verifyTemplateFields', (fields, fileId) => {
 			for (const index in body.ocs.data) {
 				const field = body.ocs.data[index]
 
+				// If a field has no name or alias, we don't need
+				// to check it because it is not shown in the template filler
+				if (!field.alias) {
+					continue;
+				}
+
 				switch (field.type) {
 				case 'rich-text':
 					expect(field.content).to.equal(fields[index].content)