Merge pull request #39362 from nextcloud/backport/39323/stable21-39323

AndyScherzinger · web-flow · commit 000214105ffd · 2023-07-13T21:32:39.000+02:00
[stable21] getStorage before remove
diff --git a/apps/files_external/lib/Service/UserStoragesService.php b/apps/files_external/lib/Service/UserStoragesService.php
@@ -140,4 +140,10 @@ public function getVisibilityType() {
 	protected function isApplicable(StorageConfig $config) {
 		return ($config->getApplicableUsers() === [$this->getUser()->getUID()]) && $config->getType() === StorageConfig::MOUNT_TYPE_PERSONAl;
 	}
+
+	public function removeStorage($id) {
+		// verify ownership through $this->isApplicable() and otherwise throws an exception
+		$this->getStorage($id);
+		parent::removeStorage($id);
+	}
 }

Original file line number	Diff line number	Diff line change
`@@ -140,4 +140,10 @@ public function getVisibilityType() {`
`140`	`140`	`protected function isApplicable(StorageConfig $config) {`
`141`	`141`	`return ($config->getApplicableUsers() === [$this->getUser()->getUID()]) && $config->getType() === StorageConfig::MOUNT_TYPE_PERSONAl;`
`142`	`142`	`}`
	`143`	`+`
	`144`	`+ public function removeStorage($id) {`
	`145`	`+ // verify ownership through $this->isApplicable() and otherwise throws an exception`
	`146`	`+ $this->getStorage($id);`
	`147`	`+ parent::removeStorage($id);`
	`148`	`+ }`
`143`	`149`	`}`