Continue iterating over diretory contents and just hide file if denied by acl

juliusknorr · juliusknorr · commit 0f23d6e28796 · 2021-04-20T17:05:37.000+02:00
Signed-off-by: Julius Härtl &lt;jus@bitgrid.net&gt;
diff --git a/apps/files_external/lib/Lib/Storage/SMB.php b/apps/files_external/lib/Lib/Storage/SMB.php
@@ -257,7 +257,7 @@ protected function getFolderContents($path): iterable {
 						// additionally, it's better to have false negatives here then false positives
 						if ($acl->denies(ACL::MASK_READ) || $acl->denies(ACL::MASK_EXECUTE)) {
 							$this->logger->debug('Hiding non readable entry ' . $file->getName());
-							return false;
+							$hide = true;
 						}
 					}
 

Original file line number	Diff line number	Diff line change
`@@ -257,7 +257,7 @@ protected function getFolderContents($path): iterable {`
`257`	`257`	`// additionally, it's better to have false negatives here then false positives`
`258`	`258`	`if ($acl->denies(ACL::MASK_READ) \|\| $acl->denies(ACL::MASK_EXECUTE)) {`
`259`	`259`	`$this->logger->debug('Hiding non readable entry ' . $file->getName());`
`260`		`- return false;`
	`260`	`+ $hide = true;`
`261`	`261`	`}`
`262`	`262`	`}`
`263`	`263`