Skip to content

Commit 1401506

Browse files
Update lib/private/AppFramework/Http/Request.php
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
1 parent a61844a commit 1401506

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

lib/private/AppFramework/Http/Request.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -576,8 +576,9 @@ protected function isTrustedProxy($trustedProxies, $remoteAddress) {
576576
try {
577577
return IpUtils::checkIp($remoteAddress, $trustedProxies);
578578
} catch (\Throwable) {
579-
// We can not log here as the logger is using `getRemoteAddress` which uses the function, so we would have a cyclic dependency
579+
// We can not log to our log here as the logger is using `getRemoteAddress` which uses the function, so we would have a cyclic dependency
580580
// Reaching this line means `trustedProxies` is in invalid format.
581+
error_log('Nextcloud trustedProxies has malformed entries');
581582
return false;
582583
}
583584
}

0 commit comments

Comments
 (0)