Skip to content

Commit 1935828

Browse files
Replace custom tooltips with native ones in users page
Signed-off-by: julia.kirschenheuter <[email protected]>
1 parent afa2953 commit 1935828

File tree

6 files changed

+21
-23
lines changed

6 files changed

+21
-23
lines changed

apps/settings/src/components/UserList/UserRow.vue

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@
9393
<div v-else class="name">
9494
{{ user.id }}
9595
<div class="displayName subtitle">
96-
<div v-tooltip="user.displayname.length > 20 ? user.displayname : ''" class="cellText">
96+
<div :title="user.displayname.length > 20 ? user.displayname : ''" class="cellText">
9797
{{ user.displayname }}
9898
</div>
9999
</div>
@@ -172,7 +172,7 @@
172172
<span slot="noResult">{{ t('settings', 'No results') }}</span>
173173
</NcMultiselect>
174174
</div>
175-
<div v-tooltip.auto="usedSpace"
175+
<div :title="usedSpace"
176176
:class="{'icon-loading-small': loading.quota}"
177177
class="quota">
178178
<NcMultiselect :allow-empty="false"
@@ -214,9 +214,9 @@
214214
class="toggleUserActions">
215215
<NcActions>
216216
<NcActionButton icon="icon-checkmark"
217-
@click="editing = false">
218-
{{ t('settings', 'Done') }}
219-
</NcActionButton>
217+
:title="t('settings', 'Done')"
218+
:aria-label="t('settings', 'Done')"
219+
@click="editing = false" />
220220
</NcActions>
221221
<div v-click-outside="hideMenu" class="userPopoverMenuWrapper">
222222
<button class="icon-more"
@@ -237,8 +237,7 @@
237237

238238
<script>
239239
import ClickOutside from 'vue-click-outside'
240-
import Vue from 'vue'
241-
import VTooltip from 'v-tooltip'
240+
242241
import {
243242
NcPopoverMenu,
244243
NcMultiselect,
@@ -248,8 +247,6 @@ import {
248247
import UserRowSimple from './UserRowSimple'
249248
import UserRowMixin from '../../mixins/UserRowMixin'
250249
251-
Vue.use(VTooltip)
252-
253250
export default {
254251
name: 'UserRow',
255252
components: {

apps/settings/src/components/UserList/UserRowSimple.vue

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
alt=""
88
width="32"
99
height="32"
10-
:src="generateAvatar(user.id, isDarkTheme)" />
10+
:src="generateAvatar(user.id, isDarkTheme)">
1111
</div>
1212
<!-- dirty hack to ellipsis on two lines -->
1313
<div class="name">
1414
<div class="displayName subtitle">
15-
<div v-tooltip="user.displayname.length > 20 ? user.displayname : ''" class="cellText">
15+
<div :title="user.displayname.length > 20 ? user.displayname : ''" class="cellText">
1616
<strong>
1717
{{ user.displayname }}
1818
</strong>
@@ -22,7 +22,7 @@
2222
</div>
2323
<div />
2424
<div class="mailAddress">
25-
<div v-tooltip="user.email !== null && user.email.length > 20 ? user.email : ''" class="cellText">
25+
<div :title="user.email !== null && user.email.length > 20 ? user.email : ''" class="cellText">
2626
{{ user.email }}
2727
</div>
2828
</div>
@@ -48,20 +48,21 @@
4848
<div v-if="showConfig.showUserBackend" class="userBackend">
4949
{{ user.backend }}
5050
</div>
51-
<div v-if="showConfig.showStoragePath" v-tooltip="user.storageLocation" class="storageLocation subtitle">
51+
<div v-if="showConfig.showStoragePath" :title="user.storageLocation" class="storageLocation subtitle">
5252
{{ user.storageLocation }}
5353
</div>
5454
</div>
55-
<div v-if="showConfig.showLastLogin" v-tooltip.auto="userLastLoginTooltip" class="lastLogin">
55+
<div v-if="showConfig.showLastLogin" :title="userLastLoginTooltip" class="lastLogin">
5656
{{ userLastLogin }}
5757
</div>
5858

5959
<div class="userActions">
6060
<div v-if="canEdit && !loading.all" class="toggleUserActions">
6161
<NcActions>
62-
<NcActionButton icon="icon-rename" @click="toggleEdit">
63-
{{ t('settings', 'Edit User') }}
64-
</NcActionButton>
62+
<NcActionButton icon="icon-rename"
63+
:title="t('settings', 'Edit User')"
64+
:aria-label="t('settings', 'Edit User')"
65+
@click="toggleEdit" />
6566
</NcActions>
6667
<div class="userPopoverMenuWrapper">
6768
<button v-click-outside="hideMenu"

dist/settings-users-8351.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/settings-users-8351.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/settings-vue-settings-apps-users-management.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/settings-vue-settings-apps-users-management.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)