Skip to content

Commit 1ab0ed8

Browse files
nickvergessencome-nc
authored andcommitted
Don't provide favorite activity settings
Since mails and notifications are only available for actions of other users it does not make sense to allow changing this. It also prevents the common misunderstanding with "file was changed inside a favorited folder" Signed-off-by: Joas Schilling <[email protected]>
1 parent a353db2 commit 1ab0ed8

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

apps/files/lib/Activity/Settings/FavoriteAction.php

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public function getPriority() {
5555
* @since 11.0.0
5656
*/
5757
public function canChangeStream() {
58-
return true;
58+
return false;
5959
}
6060

6161
/**
@@ -71,7 +71,7 @@ public function isDefaultEnabledStream() {
7171
* @since 11.0.0
7272
*/
7373
public function canChangeMail() {
74-
return true;
74+
return false;
7575
}
7676

7777
/**
@@ -81,4 +81,12 @@ public function canChangeMail() {
8181
public function isDefaultEnabledMail() {
8282
return false;
8383
}
84+
85+
/**
86+
* @return bool True when the option can be changed for the notification
87+
* @since 20.0.0
88+
*/
89+
public function canChangeNotification() {
90+
return false;
91+
}
8492
}

0 commit comments

Comments
 (0)