Remove php side of check registration

Author: nickvergessen

apps/workflowengine/appinfo/routes.php

@@ -21,7 +21,6 @@
 
 return [
 	'routes' => [
-		['name' => 'flowOperations#getChecks', 'url' => '/checks', 'verb' => 'GET'], // TODO rm and do via js?
 		['name' => 'flowOperations#getOperations', 'url' => '/operations', 'verb' => 'GET'],
 		['name' => 'flowOperations#addOperation', 'url' => '/operations', 'verb' => 'POST'],
 		['name' => 'flowOperations#updateOperation', 'url' => '/operations/{id}', 'verb' => 'PUT'],

apps/workflowengine/lib/AppInfo/Application.php

@@ -37,18 +37,6 @@ public function __construct() {
 	 */
 	public function registerHooksAndListeners() {
 		$dispatcher = $this->getContainer()->getServer()->getEventDispatcher();
-		$dispatcher->addListener(
-			'OCP\WorkflowEngine\RegisterCheckEvent',
-			function(RegisterCheckEvent $event) {
-				$event->addCheck(
-					'OCA\WorkflowEngine\Check\UserGroupMembership',
-					'User group membership',
-					['is', '!is']
-				);
-			},
-			-100
-		);
-
 		$dispatcher->addListener(
 			'OCP\WorkflowEngine::loadAdditionalSettingScripts',
 			function() {

apps/workflowengine/lib/Controller/FlowOperations.php

@@ -26,38 +26,19 @@
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\JSONResponse;
 use OCP\IRequest;
-use OCP\WorkflowEngine\RegisterCheckEvent;
-use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 
 class FlowOperations extends Controller {
 
 	/** @var Manager */
 	protected $manager;
 
-	/** @var EventDispatcherInterface */
-	protected $dispatcher;
-
 	/**
 	 * @param IRequest $request
 	 * @param Manager $manager
-	 * @param EventDispatcherInterface $dispatcher
 	 */
-	public function __construct(IRequest $request, Manager $manager, EventDispatcherInterface $dispatcher) {
+	public function __construct(IRequest $request, Manager $manager) {
 		parent::__construct('workflowengine', $request);
 		$this->manager = $manager;
-		$this->dispatcher = $dispatcher;
-	}
-
-	/**
-	 * @NoCSRFRequired
-	 *
-	 * @return JSONResponse
-	 */
-	public function getChecks() {
-		$event = new RegisterCheckEvent();
-		$this->dispatcher->dispatch('OCP\WorkflowEngine\RegisterCheckEvent', $event);
-
-		return new JSONResponse($event->getChecks());
 	}
 
 	/**

apps/workflowengine/lib/Manager.php

@@ -110,8 +110,8 @@ protected function check(array $check) {
 			$checkInstance->setFileInfo($this->storage, $this->path);
 			return $checkInstance->executeCheck($check['operator'], $check['value']);
 		} else {
-			// Check is invalid, assume it matches.
-			return true;
+			// Check is invalid
+			throw new \RuntimeException('Check ' . htmlspecialchars($check['class']) . ' is invalid or does not exist');
 		}
 	}
 
@@ -258,10 +258,12 @@ public function getChecks(array $checkIds) {
 		}
 		$result->closeCursor();
 
-		// TODO What if a check is missing? Should we throw?
-		// As long as we only allow AND-concatenation of checks, a missing check
-		// is like a matching check, so it evaluates to true and therefor blocks
-		// access. So better save than sorry.
+		$checkIds = array_diff($checkIds, array_keys($checks));
+
+		if (!empty($checkIds)) {
+			$missingCheck = array_pop($checkIds);
+			throw new \RuntimeException('Check #' . htmlspecialchars($missingCheck) . ' is invalid or does not exist');
+		}
 
 		return $checks;
 	}