Merge pull request #17252 from nextcloud/bugfix/noid/user-0-can-not-comment

Fix user with id 0 to be able to comment

Author: rullzer

lib/private/Comments/Comment.php

@@ -299,12 +299,12 @@ public function getActorId() {
 	public function setActor($actorType, $actorId) {
 		if(
 		       !is_string($actorType) || !trim($actorType)
-		    || !is_string($actorId)   || !trim($actorId)
+		    || !is_string($actorId)   || $actorId === ''
 		) {
 			throw new \InvalidArgumentException('String expected.');
 		}
 		$this->data['actorType'] = trim($actorType);
-		$this->data['actorId']   = trim($actorId);
+		$this->data['actorId']   = $actorId;
 		return $this;
 	}
 
@@ -385,7 +385,7 @@ public function getObjectId() {
 	public function setObject($objectType, $objectId) {
 		if(
 		       !is_string($objectType) || !trim($objectType)
-		    || !is_string($objectId)   || !trim($objectId)
+		    || !is_string($objectId)   || trim($objectId) === ''
 		) {
 			throw new \InvalidArgumentException('String expected.');
 		}

lib/private/Comments/Manager.php

@@ -118,9 +118,9 @@ public function getCommentFromData(array $data): IComment {
 	 */
 	protected function prepareCommentForDatabaseWrite(IComment $comment) {
 		if (!$comment->getActorType()
-			|| !$comment->getActorId()
+			|| $comment->getActorId() === ''
 			|| !$comment->getObjectType()
-			|| !$comment->getObjectId()
+			|| $comment->getObjectId() === ''
 			|| !$comment->getVerb()
 		) {
 			throw new \UnexpectedValueException('Actor, Object and Verb information must be provided for saving');