Don't use LIKE query when we have the uid

Signed-off-by: Louis Chemineau <[email protected]>

Author: artonge

apps/dav/lib/CardDAV/CardDavBackend.php

@@ -1062,6 +1062,7 @@ private function searchByAddressBookIds(array $addressBookIds,
 											array $searchProperties,
 											array $options = []): array {
 		$escapePattern = !\array_key_exists('escape_like_param', $options) || $options['escape_like_param'] !== false;
+		$strictSearch = !\array_key_exists('strict_search', $options) || $options['strict_search'] !== false;
 
 		$query2 = $this->db->getQueryBuilder();
 
@@ -1103,10 +1104,18 @@ private function searchByAddressBookIds(array $addressBookIds,
 
 		// No need for like when the pattern is empty
 		if ('' !== $pattern) {
-			if (!$escapePattern) {
-				$query2->andWhere($query2->expr()->ilike('cp.value', $query2->createNamedParameter($pattern)));
+			if ($strictSearch) {
+				if (!$escapePattern) {
+					$query2->andWhere( $query2->expr()->eq('cp.value', $query2->createNamedParameter($pattern)));
+				} else {
+					$query2->andWhere( $query2->expr()->eq('cp.value', $query2->createNamedParameter('%' . $this->db->escapeLikeParameter($pattern) . '%')));
+				}
 			} else {
-				$query2->andWhere($query2->expr()->ilike('cp.value', $query2->createNamedParameter('%' . $this->db->escapeLikeParameter($pattern) . '%')));
+				if (!$escapePattern) {
+					$query2->andWhere( $query2->expr()->ilike('cp.value', $query2->createNamedParameter($pattern)));
+				} else {
+					$query2->andWhere( $query2->expr()->ilike('cp.value', $query2->createNamedParameter('%' . $this->db->escapeLikeParameter($pattern) . '%')));
+				}
 			}
 		}
 

lib/private/Federation/CloudIdManager.php

@@ -90,7 +90,7 @@ public function resolveCloudId(string $cloudId): ICloudId {
 	}
 
 	protected function getDisplayNameFromContact(string $cloudId): ?string {
-		$addressBookEntries = $this->contactsManager->search($cloudId, ['CLOUD']);
+		$addressBookEntries = $this->contactsManager->search($cloudId, ['CLOUD'], ["strict_search" => true]);
 		foreach ($addressBookEntries as $entry) {
 			if (isset($entry['CLOUD'])) {
 				foreach ($entry['CLOUD'] as $cloudID) {