Skip to content

Commit 1f75c3f

Browse files
Add alt to the logo, adapt css for logo
Signed-off-by: julia.kirschenheuter <[email protected]>
1 parent dce8345 commit 1f75c3f

File tree

7 files changed

+24
-49
lines changed

7 files changed

+24
-49
lines changed

core/css/guest.css

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,9 @@ body {
7676
}
7777

7878
#header .logo {
79-
background-image: var(--image-logo, url('../../core/img/logo/logo.svg'));
80-
background-repeat: no-repeat;
81-
background-size: contain;
82-
background-position: center;
83-
width: 175px;
84-
height: 130px;
79+
max-width: 175px;
80+
width: auto;
81+
max-height: 130px;
8582
margin: 0 auto;
8683
position: relative;
8784
left: unset;

core/css/header.css

Lines changed: 0 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/css/header.scss

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -163,15 +163,9 @@
163163
}
164164
.logo {
165165
display: inline-flex;
166-
background-image: var(--image-logoheader, var(--image-logo, url('../img/logo/logo.svg')));
167-
background-repeat: no-repeat;
168-
background-size: contain;
169-
background-position: center;
170166
width: 62px;
171167
position: absolute;
172168
left: 12px;
173-
top: 1px;
174-
bottom: 1px;
175169
}
176170

177171
.header-appname-container {

core/css/server.css

Lines changed: 0 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/templates/layout.guest.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,11 @@
3434
<div class="v-align">
3535
<?php if ($_['bodyid'] === 'body-login'): ?>
3636
<header role="banner">
37+
<h1 class="hidden-visually">
38+
<?php p($theme->getName()); ?>
39+
</h1>
3740
<div id="header">
38-
<div class="logo">
39-
<h1 class="hidden-visually">
40-
<?php p($theme->getName()); ?>
41-
</h1>
42-
</div>
41+
<img class="logo" alt="<?php p($l->t('%s logo', [$theme->getName()])); ?>" src="<?= $_['logoUrl'].$theme->getLogo(); ?>">
4342
</div>
4443
</header>
4544
<?php endif; ?>

core/templates/layout.public.php

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -37,22 +37,20 @@
3737
</div>
3838

3939
<header id="header">
40-
<div class="header-left">
41-
<span id="nextcloud">
42-
<div class="logo logo-icon svg"></div>
43-
<h1 class="header-appname">
44-
<?php if (isset($template) && $template->getHeaderTitle() !== '') { ?>
45-
<?php p($template->getHeaderTitle()); ?>
46-
<?php } else { ?>
47-
<?php p($theme->getName()); ?>
48-
<?php } ?>
49-
</h1>
50-
<?php if (isset($template) && $template->getHeaderDetails() !== '') { ?>
51-
<div class="header-shared-by">
52-
<?php p($template->getHeaderDetails()); ?>
53-
</div>
40+
<div class="header-left" id="nextcloud">
41+
<img class="logo logo-icon svg" alt="<?php p($l->t('%s logo', [$theme->getName()])); ?>" src="<?= $_['logoUrl'].$theme->getLogo(); ?>">
42+
<h1 class="header-appname">
43+
<?php if (isset($template) && $template->getHeaderTitle() !== '') { ?>
44+
<?php p($template->getHeaderTitle()); ?>
45+
<?php } else { ?>
46+
<?php p($theme->getName()); ?>
5447
<?php } ?>
55-
</span>
48+
</h1>
49+
<?php if (isset($template) && $template->getHeaderDetails() !== '') { ?>
50+
<div class="header-shared-by">
51+
<?php p($template->getHeaderDetails()); ?>
52+
</div>
53+
<?php } ?>
5654
</div>
5755

5856
<div class="header-right">

core/templates/layout.user.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,13 @@
5757
</div>
5858

5959
<header role="banner" id="header">
60+
<h1 class="hidden-visually">
61+
<?php p($l->t('%s\'s homepage', [$theme->getName()])); ?>
62+
</h1>
6063
<div class="header-left">
6164
<a href="<?php print_unescaped($_['logoUrl'] ?: link_to('', 'index.php')); ?>"
6265
id="nextcloud">
63-
<div class="logo logo-icon">
64-
<h1 class="hidden-visually">
65-
<?php p($l->t('%s\'s homepage', [$theme->getName()])); ?>
66-
</h1>
67-
</div>
66+
<img class="logo logo-icon" alt="<?php p($l->t('%s logo', [$theme->getName()])); ?>" src="<?= $_['logoUrl'].$theme->getLogo(); ?>">
6867
</a>
6968

7069
<nav id="header-left__appmenu"></nav>

0 commit comments

Comments
 (0)