Merge pull request #29400 from nextcloud/fix/noid/undef-index-error

juliusknorr · web-flow · commit 2b651cc02206 · 2021-10-23T14:46:36.000+02:00
fixes an undefined index when getAccessList returns an empty array
diff --git a/apps/workflowengine/lib/Entity/File.php b/apps/workflowengine/lib/Entity/File.php
@@ -141,7 +141,7 @@ public function isLegitimatedForUserId(string $uid): bool {
 				return true;
 			}
 			$acl = $this->shareManager->getAccessList($node, true, true);
-			return array_key_exists($uid, $acl['users']);
+			return isset($acl['users']) && array_key_exists($uid, $acl['users']);
 		} catch (NotFoundException $e) {
 			return false;
 		}

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ public function isLegitimatedForUserId(string $uid): bool {`
`141`	`141`	`return true;`
`142`	`142`	`}`
`143`	`143`	`$acl = $this->shareManager->getAccessList($node, true, true);`
`144`		`- return array_key_exists($uid, $acl['users']);`
	`144`	`+ return isset($acl['users']) && array_key_exists($uid, $acl['users']);`
`145`	`145`	`} catch (NotFoundException $e) {`
`146`	`146`	`return false;`
`147`	`147`	`}`