Skip to content

Commit 2dfaa9c

Browse files
committed
Only build JSConfig in TemplateLayout when it is actually used
Signed-off-by: Morris Jobke <[email protected]>
1 parent 8eb0db5 commit 2dfaa9c

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

lib/private/TemplateLayout.php

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -194,21 +194,21 @@ public function __construct($renderAs, $appId = '') {
194194
$jsFiles = self::findJavascriptFiles(\OC_Util::$scripts);
195195
$this->assign('jsfiles', []);
196196
if ($this->config->getSystemValue('installed', false) && $renderAs != TemplateResponse::RENDER_AS_ERROR) {
197-
$jsConfigHelper = new JSConfigHelper(
198-
\OC::$server->getL10N('lib'),
199-
\OC::$server->query(Defaults::class),
200-
\OC::$server->getAppManager(),
201-
\OC::$server->getSession(),
202-
\OC::$server->getUserSession()->getUser(),
203-
$this->config,
204-
\OC::$server->getGroupManager(),
205-
\OC::$server->get(IniGetWrapper::class),
206-
\OC::$server->getURLGenerator(),
207-
\OC::$server->getCapabilitiesManager(),
208-
\OC::$server->query(IInitialStateService::class)
209-
);
210-
$config = $jsConfigHelper->getConfig();
211197
if (\OC::$server->getContentSecurityPolicyNonceManager()->browserSupportsCspV3()) {
198+
$jsConfigHelper = new JSConfigHelper(
199+
\OC::$server->getL10N('lib'),
200+
\OC::$server->query(Defaults::class),
201+
\OC::$server->getAppManager(),
202+
\OC::$server->getSession(),
203+
\OC::$server->getUserSession()->getUser(),
204+
$this->config,
205+
\OC::$server->getGroupManager(),
206+
\OC::$server->get(IniGetWrapper::class),
207+
\OC::$server->getURLGenerator(),
208+
\OC::$server->getCapabilitiesManager(),
209+
\OC::$server->query(IInitialStateService::class)
210+
);
211+
$config = $jsConfigHelper->getConfig();
212212
$this->assign('inline_ocjs', $config);
213213
} else {
214214
$this->append('jsfiles', \OC::$server->getURLGenerator()->linkToRoute('core.OCJS.getConfig', ['v' => self::$versionHash]));

0 commit comments

Comments
 (0)