Rollback failed transactions in TestCase.php to not break followup tests

Signed-off-by: Morris Jobke <[email protected]>

Author: MorrisJobke

tests/lib/DB/MigratorTest.php

@@ -142,7 +142,7 @@ public function testDuplicateKeyUpgrade() {
 
 		try {
 			$migrator->migrate($endSchema);
-		} catch(Exception\UniqueConstraintViolationException $e) {
+		} catch (Exception\UniqueConstraintViolationException $e) {
 			$this->connection->rollBack();
 			throw $e;
 		}

tests/lib/TestCase.php

@@ -261,7 +261,12 @@ public static function tearDownAfterClass(): void {
 		}
 		$dataDir = \OC::$server->getConfig()->getSystemValue('datadirectory', \OC::$SERVERROOT . '/data-autotest');
 		if (self::$wasDatabaseAllowed && \OC::$server->getDatabaseConnection()) {
-			$queryBuilder = \OC::$server->getDatabaseConnection()->getQueryBuilder();
+			$db = \OC::$server->getDatabaseConnection();
+			if ($db->inTransaction()) {
+				$db->rollBack();
+				throw new \Exception('There was a transaction still in progress and needed to be rolled back. Please fix this in your test.');
+			}
+			$queryBuilder = $db->getQueryBuilder();
 
 			self::tearDownAfterClassCleanShares($queryBuilder);
 			self::tearDownAfterClassCleanStorages($queryBuilder);