Merge pull request #27675 from nextcloud/bugfix/noid/fix-setting-theming-color

Validate the theming color also on CLI

Author: juliusknorr

apps/theming/lib/Command/UpdateConfig.php

@@ -127,6 +127,11 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 			$key = $key . 'Mime';
 		}
 
+		if ($key === 'color' && !preg_match('/^\#([0-9a-f]{3}|[0-9a-f]{6})$/i', $value)) {
+			$output->writeln('<error>The given color is invalid: ' . $value . '</error>');
+			return 1;
+		}
+
 		$this->themingDefaults->set($key, $value);
 		$output->writeln('<info>Updated ' . $key . ' to ' . $value . '</info>');
 

apps/theming/lib/ThemingDefaults.php

@@ -220,7 +220,11 @@ public function getShortFooter() {
 	 * @return string
 	 */
 	public function getColorPrimary() {
-		return $this->config->getAppValue('theming', 'color', $this->color);
+		$color = $this->config->getAppValue('theming', 'color', $this->color);
+		if (!preg_match('/^\#([0-9a-f]{3}|[0-9a-f]{6})$/i', $color)) {
+			$color = '#0082c9';
+		}
+		return $color;
 	}
 
 	/**