Implement review feedback

Signed-off-by: Lukas Reschke <[email protected]>

Author: LukasReschke

core/Migrations/Version23000Date20210906132259.php

@@ -34,8 +34,8 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
 			$table->addColumn('delete_after', Types::DATETIME, [
 				'notnull' => true,
 			]);
-			$table->addIndex(['hash'], 'ratelimit_hash_idx');
-			$table->addIndex(['delete_after'], 'ratelimit_delete_after_idx');
+			$table->addIndex(['hash'], 'ratelimit_hash');
+			$table->addIndex(['delete_after'], 'ratelimit_delete_after');
 			return $schema;
 		}
 

lib/private/Security/RateLimiting/Backend/DatabaseBackend.php

@@ -74,7 +74,7 @@ private function getExistingAttemptCount(
 		$qb->delete(self::TABLE_NAME)
 			->where(
 				$qb->expr()->lte('delete_after', $qb->createNamedParameter($currentTime, IQueryBuilder::PARAM_DATE))
-			);
+			)
 			->executeStatement();
 
 		$qb = $this->dbConnection->getQueryBuilder();
@@ -88,10 +88,10 @@ private function getExistingAttemptCount(
 			);
 
 		$cursor = $qb->executeQuery();
-		$row = $cursor->fetch();
+		$row = $cursor->fetchOne();
 		$cursor->closeCursor();
 
-		return (int)$row['count'];
+		return (int)$row;
 	}
 
 	/**