fix user creation using LDAP Plugin

Signed-off-by: Vinicius Cubas Brand <[email protected]>

Author: viniciuscb

apps/user_ldap/lib/UserPluginManager.php

@@ -84,7 +84,7 @@ public function implementsActions($actions) {
 	 *
 	 * @param string $username The username of the user to create
 	 * @param string $password The password of the new user
-	 * @return bool
+	 * @return string | null The group DN if group creation was successful.
 	 * @throws \Exception
 	 */
 	public function createUser($username, $password) {

apps/user_ldap/lib/User_LDAP.php

@@ -615,13 +615,23 @@ public function getNewLDAPConnection($uid) {
 	 * create new user
 	 * @param string $username username of the new user
 	 * @param string $password password of the new user
-	 * @return bool was the user created?
+	 * @return bool
+	 * @throws \Exception
 	 */
 	public function createUser($username, $password) {
 		if ($this->userPluginManager->implementsActions(Backend::CREATE_USER)) {
-			return $this->userPluginManager->createUser($username, $password);
+			if ($dn = $this->userPluginManager->createUser($username, $password)) {
+				if (is_string($dn)) {
+					//updates group mapping
+					$this->access->dn2ocname($dn, $username, true);
+					$this->access->connection->writeToCache("userExists".$username, true);
+				} else {
+					throw new \Exception("LDAP Plugin: Method createUser changed to return the user DN instead of boolean.");
+				}
+			}
+			return $dn != null;
 		}
-		return false;
+		throw new \Exception('Could not create user in LDAP backend.');
 	}
 
 }

apps/user_ldap/tests/User_LDAPTest.php

@@ -1422,16 +1422,19 @@ public function testCreateUserWithPlugin() {
 			->with('uid','password')
 			->willReturn('result');
 
-		$this->assertEquals($this->backend->createUser('uid', 'password'),'result');
+		$this->assertEquals($this->backend->createUser('uid', 'password'),true);
 	}
 
+	/**
+	 * @expectedException \Exception
+	 */
 	public function testCreateUserFailing() {
 		$this->pluginManager->expects($this->once())
 			->method('implementsActions')
 			->with(Backend::CREATE_USER)
 			->willReturn(false);
 
-		$this->assertFalse($this->backend->createUser('uid', 'password'));
+		$this->backend->createUser('uid', 'password');
 	}
 
 	public function actionProvider() {