do not offer to change display name or password, if not possible.

Fixes #12319

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Author: blizzz

apps/provisioning_api/lib/Controller/AUserData.php

@@ -22,6 +22,7 @@
 namespace OCA\Provisioning_API\Controller;
 
 use OC\Accounts\AccountManager;
+use OC\User\Backend;
 use OCP\AppFramework\OCS\OCSException;
 use OCP\AppFramework\OCS\OCSNotFoundException;
 use OCP\AppFramework\OCSController;
@@ -32,6 +33,8 @@
 use OCP\IRequest;
 use OCP\IUserManager;
 use OCP\IUserSession;
+use OCP\User\Backend\ISetDisplayNameBackend;
+use OCP\User\Backend\ISetPasswordBackend;
 
 abstract class AUserData extends OCSController {
 
@@ -125,6 +128,12 @@ protected function getUserData(string $userId): array {
 		$data['language'] = $this->config->getUserValue($targetUserObject->getUID(), 'core', 'lang');
 		$data['locale'] = $this->config->getUserValue($targetUserObject->getUID(), 'core', 'locale');
 
+		$backend = $targetUserObject->getBackend();
+		$data['backendCapabilities'] = [
+			'setDisplayName' => $backend instanceof ISetDisplayNameBackend || $backend->implementsActions(Backend::SET_DISPLAYNAME),
+			'setPassword' => $backend instanceof ISetPasswordBackend || $backend->implementsActions(Backend::SET_PASSWORD),
+		];
+
 		return $data;
     }
 

lib/public/IUser.php

@@ -26,6 +26,8 @@
 
 namespace OCP;
 
+use OCP\UserInterface;
+
 /**
  * Interface IUser
  *
@@ -111,6 +113,7 @@ public function getBackendClassName();
 	/**
 	 * Get the backend for the current user object
 	 *
+	 * @return UserInterface
 	 * @since 15.0.0
 	 */
 	public function getBackend();

settings/js/4.js.map

@@ -42,13 +42,15 @@
 		<!-- dirty hack to ellipsis on two lines -->
 		<div class="name">{{user.id}}</div>
 		<form class="displayName" :class="{'icon-loading-small': loading.displayName}" v-on:submit.prevent="updateDisplayName">
-			<input :id="'displayName'+user.id+rand" type="text"
+			<input v-if="user.backendCapabilities.setDisplayName"
+				    :id="'displayName'+user.id+rand" type="text"
 					:disabled="loading.displayName||loading.all"
 					:value="user.displayname" ref="displayName"
 					autocomplete="new-password" autocorrect="off" autocapitalize="off" spellcheck="false" />
-			<input type="submit" class="icon-confirm" value="" />
+			<input v-if="user.backendCapabilities.setDisplayName" type="submit" class="icon-confirm" value="" />
+			<div v-if="!user.backendCapabilities.setDisplayName" class="name">{{user.displayname}}</div>
 		</form>
-		<form class="password" v-if="settings.canChangePassword" :class="{'icon-loading-small': loading.password}"
+		<form class="password" v-if="settings.canChangePassword && user.backendCapabilities.setPassword" :class="{'icon-loading-small': loading.password}"
 			  v-on:submit.prevent="updatePassword">
 			<input :id="'password'+user.id+rand" type="password" required
 					:disabled="loading.password||loading.all" :minlength="minPasswordLength"