Skip to content

Commit 68a1557

Browse files
committed
Use aria-expanded correctly on toggle user actions
The aria-expanded attribute was added on the expandable item rather Than the button that triggers the expand. Resolves : #37137 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
1 parent 85df0f6 commit 68a1557

File tree

9 files changed

+13
-42
lines changed

9 files changed

+13
-42
lines changed

apps/settings/src/components/UserList/UserRow.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,8 @@
250250
</NcActions>
251251
<div v-click-outside="hideMenu" class="userPopoverMenuWrapper">
252252
<button class="icon-more"
253+
:aria-expanded="openedMenu"
254+
:aria-label="t('settings', 'Toggle user actions menu')"
253255
@click.prevent="toggleMenu" />
254256
<div :class="{ 'open': openedMenu }" class="popovermenu">
255257
<NcPopoverMenu :menu="userActions" />

apps/settings/src/components/UserList/UserRowSimple.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,10 @@
6969
<div class="userPopoverMenuWrapper">
7070
<button v-click-outside="hideMenu"
7171
class="icon-more"
72+
:aria-expanded="openedMenu"
7273
:aria-label="t('settings', 'Toggle user actions menu')"
7374
@click.prevent="toggleMenu" />
74-
<div class="popovermenu" :class="{ 'open': openedMenu }" :aria-expanded="openedMenu">
75+
<div class="popovermenu" :class="{ 'open': openedMenu }">
7576
<NcPopoverMenu :menu="userActions" />
7677
</div>
7778
</div>

dist/core-common.js

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)