Update lib/private/Share20/Manager.php

Co-authored-by: Louis <6653109+artonge@users.noreply.github.com>

Author: CarlSchwan

lib/private/Share20/Manager.php

@@ -1788,15 +1788,12 @@ public function shareApiAllowLinks() {
 	 * @return bool
 	 */
 	public function shareApiLinkEnforcePassword(bool $checkGroupMembership = true) {
-		$excludedGroups = $this->config->getAppValue('core', 'shareapi_enforce_links_password_excluded_groups', '');
-		if ($excludedGroups !== '' && $checkGroupMembership) {
-			$excludedGroups = json_decode($excludedGroups);
-			$user = $this->userSession->getUser();
-			if ($user) {
-				$userGroups = $this->groupManager->getUserGroupIds($user);
-				if ((bool)array_intersect($excludedGroups, $userGroups)) {
-					return false;
-				}
+		$user = $this->userSession->getUser();
+		if ($checkGroupMembership && $user !== null) {
+			$userGroups = $this->groupManager->getUserGroupIds($user);
+			$excludedGroups = json_decode($this->config->getAppValue('core', 'shareapi_enforce_links_password_excluded_groups', '[]'));
+			if (count(array_intersect($excludedGroups, $userGroups)) > 0) {
+				return false;
 			}
 		}
 		return $this->config->getAppValue('core', 'shareapi_enforce_links_password', 'no') === 'yes';