Skip to content

Commit 72a11e0

Browse files
committed
Emit sidebar events
Signed-off-by: Louis Chemineau <[email protected]>
1 parent b908db7 commit 72a11e0

File tree

10 files changed

+61
-36
lines changed

10 files changed

+61
-36
lines changed

apps/files/js/dist/files-app-settings.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/files/js/dist/personal-settings.js

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/files/js/dist/personal-settings.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/files/js/dist/sidebar.js

Lines changed: 14 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/files/js/dist/sidebar.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/files/js/dist/templates.js

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/files/js/dist/templates.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/files/src/views/Sidebar.vue

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@
2121
-->
2222

2323
<template>
24+
<!--
25+
For the 'handleClosed' event listener, we need to listen to the 'hook:destroyed' event instead of the 'closed' event.
26+
This is necessary because with v-if, the 'closed' event is emitted after the destruction of AppSidebar, and all the event listeners are unbound and won't be triggered.
27+
-->
2428
<AppSidebar
2529
v-if="file"
2630
ref="sidebar"
@@ -29,7 +33,11 @@
2933
@close="close"
3034
@update:active="setActiveTab"
3135
@update:starred="toggleStarred"
32-
@[defaultActionListener].stop.prevent="onDefaultAction">
36+
@[defaultActionListener].stop.prevent="onDefaultAction"
37+
@opening="handleOpening"
38+
@opened="handleOpened"
39+
@closing="handleClosing"
40+
@closed="handleClosed">
3341
<!-- TODO: create a standard to allow multiple elements here? -->
3442
<template v-if="fileInfo" #description>
3543
<LegacyView v-for="view in views"
@@ -78,6 +86,7 @@
7886
import { encodePath } from '@nextcloud/paths'
7987
import $ from 'jquery'
8088
import axios from '@nextcloud/axios'
89+
import { emit } from '@nextcloud/event-bus'
8190
import AppSidebar from '@nextcloud/vue/dist/Components/AppSidebar'
8291
import ActionButton from '@nextcloud/vue/dist/Components/ActionButton'
8392
import EmptyContent from '@nextcloud/vue/dist/Components/EmptyContent'
@@ -422,6 +431,22 @@ export default {
422431
this.Sidebar.file = ''
423432
this.resetData()
424433
},
434+
435+
/**
436+
* Emit SideBar events.
437+
*/
438+
handleOpening() {
439+
emit('files:sidebar:opening')
440+
},
441+
handleOpened() {
442+
emit('files:sidebar:opened')
443+
},
444+
handleClosing() {
445+
emit('files:sidebar:closing')
446+
},
447+
handleClosed() {
448+
emit('files:sidebar:closed')
449+
},
425450
},
426451
}
427452
</script>

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"@nextcloud/axios": "^1.6.0",
3131
"@nextcloud/capabilities": "^1.0.4",
3232
"@nextcloud/dialogs": "^3.1.2",
33-
"@nextcloud/event-bus": "^1.2.0",
33+
"@nextcloud/event-bus": "^1.3.0",
3434
"@nextcloud/files": "^1.1.0",
3535
"@nextcloud/initial-state": "^1.2.0",
3636
"@nextcloud/l10n": "^1.4.1",

0 commit comments

Comments
 (0)