Merge pull request #16883 from nextcloud/backport/16875/stable16

[stable16] Use custom client URL in welcome emails

Author: rullzer

settings/Mailer/NewUserMailHelper.php

@@ -148,7 +148,7 @@ public function generateTemplate(IUser $user, $generatePasswordResetToken = fals
 			$leftButtonText,
 			$link,
 			$l10n->t('Install Client'),
-			'https://nextcloud.com/install/#install-clients'
+			$this->config->getSystemValue('customclient_desktop', 'https://nextcloud.com/install/#install-clients')
 		);
 		$emailTemplate->addFooter();
 

tests/Settings/Mailer/NewUserMailHelperTest.php

@@ -79,6 +79,18 @@ public function setUp() {
 		$this->secureRandom = $this->createMock(ISecureRandom::class);
 		$this->timeFactory = $this->createMock(ITimeFactory::class);
 		$this->config = $this->createMock(IConfig::class);
+		$this->config
+			->expects($this->any())
+			->method('getSystemValue')
+			->willReturnCallback(function($arg) {
+				switch ($arg) {
+					case 'secret':
+						return 'MyInstanceWideSecret';
+					case 'customclient_desktop':
+						return 'https://nextcloud.com/install/#install-clients';
+				}
+				return '';
+			});
 		$this->crypto = $this->createMock(ICrypto::class);
 		$this->l10n->method('t')
 			->will($this->returnCallback(function ($text, $parameters = []) {
@@ -122,11 +134,6 @@ public function testGenerateTemplateWithPasswordResetToken() {
 			->expects($this->any())
 			->method('getEmailAddress')
 			->willReturn('[email protected]');
-		$this->config
-			->expects($this->any())
-			->method('getSystemValue')
-			->with('secret')
-			->willReturn('MyInstanceWideSecret');
 		$this->crypto
 			->expects($this->once())
 			->method('encrypt')