simplify getGroups, fixing wrong chunking logic

pagination is taken care of properly in the search logic in Access class

Signed-off-by: Arthur Schiwon <[email protected]>

Author: blizzz

apps/user_ldap/lib/Group_LDAP.php

@@ -1002,14 +1002,17 @@ public function countUsersInGroup($gid, $search = '') {
 	}
 
 	/**
-	 * get a list of all groups
+	 * get a list of all groups using a paged search
 	 *
 	 * @param string $search
-	 * @param $limit
+	 * @param int $limit
 	 * @param int $offset
 	 * @return array with group names
 	 *
-	 * Returns a list with all groups (used by getGroups)
+	 * Returns a list with all groups
+	 * Uses a paged search if available to override a
+	 * server side search limit.
+	 * (active directory has a limit of 1000 by default)
 	 */
 	protected function getGroupsChunk($search = '', $limit = -1, $offset = 0) {
 		if(!$this->enabled) {