Merge pull request #41451 from nextcloud/backport/41447/stable27

blizzz · web-flow · commit 7d507d24ffd6 · 2023-12-05T23:08:54.000+01:00
[stable27] fix(backupcodes): Remove old notifications before creating a new remi…
diff --git a/apps/twofactor_backupcodes/lib/BackgroundJob/RememberBackupCodesJob.php b/apps/twofactor_backupcodes/lib/BackgroundJob/RememberBackupCodesJob.php
@@ -94,9 +94,11 @@ protected function run($argument) {
 		$notification = $this->notificationManager->createNotification();
 		$notification->setApp('twofactor_backupcodes')
 			->setUser($user->getUID())
-			->setDateTime($date)
 			->setObject('create', 'codes')
 			->setSubject('create_backupcodes');
+		$this->notificationManager->markProcessed($notification);
+
+		$notification->setDateTime($date);
 		$this->notificationManager->notify($notification);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -94,9 +94,11 @@ protected function run($argument) {`
`94`	`94`	`$notification = $this->notificationManager->createNotification();`
`95`	`95`	`$notification->setApp('twofactor_backupcodes')`
`96`	`96`	`->setUser($user->getUID())`
`97`		`- ->setDateTime($date)`
`98`	`97`	`->setObject('create', 'codes')`
`99`	`98`	`->setSubject('create_backupcodes');`
	`99`	`+ $this->notificationManager->markProcessed($notification);`
	`100`	`+`
	`101`	`+ $notification->setDateTime($date);`
`100`	`102`	`$this->notificationManager->notify($notification);`
`101`	`103`	`}`
`102`	`104`	`}`