strict comparison is preferred

olivermg · olivermg · commit 80d32166ccdf · 2018-10-26T16:07:18.000+02:00
diff --git a/lib/private/AppFramework/Http/Request.php b/lib/private/AppFramework/Http/Request.php
@@ -611,7 +611,7 @@ protected function matchesTrustedProxy($trustedProxy, $remoteAddress) {
 			$netnum = ip2long($net) >> $shiftbits;
 			$ipnum = ip2long($remoteAddress) >> $shiftbits;
 
-			return $ipnum == $netnum;
+			return $ipnum === $netnum;
 		}
 
 		return $trustedProxy === $remoteAddress;

Original file line number	Diff line number	Diff line change
`@@ -611,7 +611,7 @@ protected function matchesTrustedProxy($trustedProxy, $remoteAddress) {`
`611`	`611`	`$netnum = ip2long($net) >> $shiftbits;`
`612`	`612`	`$ipnum = ip2long($remoteAddress) >> $shiftbits;`
`613`	`613`
`614`		`- return $ipnum == $netnum;`
	`614`	`+ return $ipnum === $netnum;`
`615`	`615`	`}`
`616`	`616`
`617`	`617`	`return $trustedProxy === $remoteAddress;`