Apply suggestions from code review

Co-authored-by: Carl Schwan <[email protected]>

Author: skjnldsv

apps/accessibility/lib/Controller/AccessibilityController.php

@@ -247,6 +247,9 @@ private function isDarkThemeEnabled(): bool {
 			return false;
 		}
 		$user = $this->userSession->getUser();
+		if (!$user) {
+			return false;
+		}
 		return $this->config->getUserValue($user->getUID(), $this->appName, 'theme', false) === 'dark';
 	}
 }

apps/theming/lib/ThemingDefaults.php

@@ -315,7 +315,7 @@ public function getFDroidClientUrl() {
 	/**
 	 * @return array scss variables to overwrite
 	 */
-	public function getScssVariables($brightBackground = true) {
+	public function getScssVariables(bool $brightBackground = true) {
 		$cacheBuster = $this->config->getAppValue('theming', 'cachebuster', '0');
 		$cache = $this->cacheFactory->createDistributed('theming-' . $cacheBuster . '-' . $this->urlGenerator->getBaseUrl());
 		if ($value = $cache->get('getScssVariables')) {

lib/private/legacy/OC_Defaults.php

@@ -311,7 +311,7 @@ public function getColorPrimary() {
 	/**
 	 * @return array scss variables to overwrite
 	 */
-	public function getScssVariables($brightBackground = true) {
+	public function getScssVariables(bool $brightBackground = true) {
 		if ($this->themeExist('getScssVariables')) {
 			return $this->theme->getScssVariables($brightBackground);
 		}

themes/example/defaults.php

@@ -119,7 +119,7 @@ public function getColorPrimary() {
 	 * Returns variables to overload defaults from core/css/variables.scss
 	 * @return array
 	 */
-	public function getScssVariables($brightBackground) {
+	public function getScssVariables(bool $brightBackground) {
 		return [
 			'color-primary' => '#745bca'
 		];