Merge pull request #17148 from nextcloud/always-provide-color-to-default-personal-calendar

Always provide theme color for default personal calendar

Author: nickvergessen

apps/dav/lib/HookManager.php

@@ -31,6 +31,7 @@
 use OCA\DAV\CalDAV\CalDavBackend;
 use OCA\DAV\CardDAV\CardDavBackend;
 use OCA\DAV\CardDAV\SyncService;
+use OCP\Defaults;
 use OCP\IUser;
 use OCP\IUserManager;
 use OCP\Util;
@@ -59,18 +60,23 @@ class HookManager {
 	/** @var array */
 	private $addressBooksToDelete = [];
 
+	/** @var Defaults */
+	private $themingDefaults;
+
 	/** @var EventDispatcherInterface */
 	private $eventDispatcher;
 
 	public function __construct(IUserManager $userManager,
 								SyncService $syncService,
 								CalDavBackend $calDav,
 								CardDavBackend $cardDav,
+								Defaults $themingDefaults,
 								EventDispatcherInterface $eventDispatcher) {
 		$this->userManager = $userManager;
 		$this->syncService = $syncService;
 		$this->calDav = $calDav;
 		$this->cardDav = $cardDav;
+		$this->themingDefaults = $themingDefaults;
 		$this->eventDispatcher = $eventDispatcher;
 	}
 
@@ -156,6 +162,8 @@ public function firstLogin(IUser $user = null) {
 				try {
 					$this->calDav->createCalendar($principal, CalDavBackend::PERSONAL_CALENDAR_URI, [
 						'{DAV:}displayname' => CalDavBackend::PERSONAL_CALENDAR_NAME,
+						'{http://apple.com/ns/ical/}calendar-color' => $this->themingDefaults->getColorPrimary(),
+						'components' => 'VEVENT'
 					]);
 				} catch (\Exception $ex) {
 					\OC::$server->getLogger()->logException($ex);

apps/dav/tests/unit/DAV/HookManagerTest.php

@@ -34,6 +34,7 @@
 use OCA\DAV\CardDAV\CardDavBackend;
 use OCA\DAV\CardDAV\SyncService;
 use OCA\DAV\HookManager;
+use OCP\Defaults;
 use OCP\IL10N;
 use OCP\IUser;
 use OCP\IUserManager;
@@ -75,14 +76,25 @@ public function test() {
 			->disableOriginalConstructor()
 			->getMock();
 
+		/** @var Defaults | \PHPUnit\Framework\MockObject\MockObject $syncService */
+		$defaults = $this->getMockBuilder(Defaults::class)
+			->disableOriginalConstructor()
+			->getMock();
+
+		$defaults->expects($this->once())->method('getColorPrimary')->willReturn('#745bca');
+
 		/** @var CalDavBackend | \PHPUnit\Framework\MockObject\MockObject $cal */
 		$cal = $this->getMockBuilder(CalDavBackend::class)
 			->disableOriginalConstructor()
 			->getMock();
 		$cal->expects($this->once())->method('getCalendarsForUserCount')->willReturn(0);
 		$cal->expects($this->once())->method('createCalendar')->with(
 			'principals/users/newUser',
-			'personal', ['{DAV:}displayname' => 'Personal']);
+			'personal', [
+				'{DAV:}displayname' => 'Personal',
+				'{http://apple.com/ns/ical/}calendar-color' => '#745bca',
+				'components' => 'VEVENT'
+			]);
 
 		/** @var CardDavBackend | \PHPUnit\Framework\MockObject\MockObject $card */
 		$card = $this->getMockBuilder(CardDavBackend::class)
@@ -93,7 +105,7 @@ public function test() {
 			'principals/users/newUser',
 			'contacts', ['{DAV:}displayname' => 'Contacts']);
 
-		$hm = new HookManager($userManager, $syncService, $cal, $card, $this->eventDispatcher);
+		$hm = new HookManager($userManager, $syncService, $cal, $card, $defaults, $this->eventDispatcher);
 		$hm->firstLogin($user);
 	}
 
@@ -113,6 +125,11 @@ public function testWithExisting() {
 			->disableOriginalConstructor()
 			->getMock();
 
+		/** @var Defaults | \PHPUnit\Framework\MockObject\MockObject $syncService */
+		$defaults = $this->getMockBuilder(Defaults::class)
+			->disableOriginalConstructor()
+			->getMock();
+
 		/** @var CalDavBackend | \PHPUnit\Framework\MockObject\MockObject $cal */
 		$cal = $this->getMockBuilder(CalDavBackend::class)
 			->disableOriginalConstructor()
@@ -127,7 +144,7 @@ public function testWithExisting() {
 		$card->expects($this->once())->method('getAddressBooksForUserCount')->willReturn(1);
 		$card->expects($this->never())->method('createAddressBook');
 
-		$hm = new HookManager($userManager, $syncService, $cal, $card, $this->eventDispatcher);
+		$hm = new HookManager($userManager, $syncService, $cal, $card, $defaults, $this->eventDispatcher);
 		$hm->firstLogin($user);
 	}
 
@@ -147,14 +164,24 @@ public function testWithBirthdayCalendar() {
 			->disableOriginalConstructor()
 			->getMock();
 
+		/** @var Defaults | \PHPUnit\Framework\MockObject\MockObject $syncService */
+		$defaults = $this->getMockBuilder(Defaults::class)
+			->disableOriginalConstructor()
+			->getMock();
+		$defaults->expects($this->once())->method('getColorPrimary')->willReturn('#745bca');
+
 		/** @var CalDavBackend | \PHPUnit\Framework\MockObject\MockObject $cal */
 		$cal = $this->getMockBuilder(CalDavBackend::class)
 			->disableOriginalConstructor()
 			->getMock();
 		$cal->expects($this->once())->method('getCalendarsForUserCount')->willReturn(0);
 		$cal->expects($this->once())->method('createCalendar')->with(
 			'principals/users/newUser',
-			'personal', ['{DAV:}displayname' => 'Personal']);
+			'personal', [
+				'{DAV:}displayname' => 'Personal',
+				'{http://apple.com/ns/ical/}calendar-color' => '#745bca',
+				'components' => 'VEVENT'
+			]);
 
 		/** @var CardDavBackend | \PHPUnit\Framework\MockObject\MockObject $card */
 		$card = $this->getMockBuilder(CardDavBackend::class)
@@ -165,7 +192,7 @@ public function testWithBirthdayCalendar() {
 			'principals/users/newUser',
 			'contacts', ['{DAV:}displayname' => 'Contacts']);
 
-		$hm = new HookManager($userManager, $syncService, $cal, $card, $this->eventDispatcher);
+		$hm = new HookManager($userManager, $syncService, $cal, $card, $defaults, $this->eventDispatcher);
 		$hm->firstLogin($user);
 	}
 
@@ -187,6 +214,11 @@ public function testDeleteCalendar() {
 		$syncService->expects($this->once())
 			->method('deleteUser');
 
+		/** @var Defaults | \PHPUnit\Framework\MockObject\MockObject $syncService */
+		$defaults = $this->getMockBuilder(Defaults::class)
+			->disableOriginalConstructor()
+			->getMock();
+
 		/** @var CalDavBackend | \PHPUnit\Framework\MockObject\MockObject $cal */
 		$cal = $this->getMockBuilder(CalDavBackend::class)
 			->disableOriginalConstructor()
@@ -206,7 +238,7 @@ public function testDeleteCalendar() {
 		]);
 		$card->expects($this->once())->method('deleteAddressBook');
 
-		$hm = new HookManager($userManager, $syncService, $cal, $card, $this->eventDispatcher);
+		$hm = new HookManager($userManager, $syncService, $cal, $card, $defaults, $this->eventDispatcher);
 		$hm->preDeleteUser(['uid' => 'newUser']);
 		$hm->postDeleteUser(['uid' => 'newUser']);
 	}