Remove useless coalescing operator on non-null return value

come-nc · come-nc · commit 9442cce9b07a · 2023-03-30T11:18:31.000+02:00
Signed-off-by: Côme Chilliet &lt;come.chilliet@nextcloud.com&gt;
diff --git a/lib/private/Files/Storage/Local.php b/lib/private/Files/Storage/Local.php
@@ -249,7 +249,7 @@ public function filesize($path): false|int|float {
 		$fullPath = $this->getSourcePath($path);
 		if (PHP_INT_SIZE === 4) {
 			$helper = new \OC\LargeFileHelper;
-			return $helper->getFileSize($fullPath) ?? false;
+			return $helper->getFileSize($fullPath);
 		}
 		return filesize($fullPath);
 	}

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ public function filesize($path): false\|int\|float {`
`249`	`249`	`$fullPath = $this->getSourcePath($path);`
`250`	`250`	`if (PHP_INT_SIZE === 4) {`
`251`	`251`	`$helper = new \OC\LargeFileHelper;`
`252`		`- return $helper->getFileSize($fullPath) ?? false;`
	`252`	`+ return $helper->getFileSize($fullPath);`
`253`	`253`	`}`
`254`	`254`	`return filesize($fullPath);`
`255`	`255`	`}`