Improve handling of profile fields

Signed-off-by: Christopher Ng <[email protected]>
(cherry picked from commit a94c5fb)
Signed-off-by: nextcloud-command <[email protected]>

Author: Pytal

apps/provisioning_api/lib/Controller/UsersController.php

@@ -627,6 +627,7 @@ public function getEditableFieldsForUser(string $userId): DataResponse {
 	 * @NoAdminRequired
 	 * @NoSubAdminRequired
 	 * @PasswordConfirmationRequired
+	 * @UserRateThrottle(limit=5, period=60)
 	 *
 	 * @throws OCSException
 	 */
@@ -719,6 +720,7 @@ public function editUserMultiValue(
 	 * @NoAdminRequired
 	 * @NoSubAdminRequired
 	 * @PasswordConfirmationRequired
+	 * @UserRateThrottle(limit=50, period=600)
 	 *
 	 * edit users
 	 *

apps/settings/js/federationsettingsview.js

@@ -164,6 +164,10 @@
 				} else {
 					self._showInputChangeFail(field);
 				}
+			}).fail(function(data) {
+				if (data.status === 429) {
+					OC.Notification.showTemporary(t('settings', 'There were too many requests from your network. Retry later or contact your administrator if this is an error.'))
+				}
 			});
 		},
 
@@ -181,7 +185,12 @@
 			$('#' + field + 'scope').val(scope);
 
 			// TODO: user loading/success feedback
-			this._config.save();
+			var savingData = this._config.save();
+			$.when(savingData).fail(function(data) {
+				if (data.status === 429) {
+					OC.Notification.showTemporary(t('settings', 'There were too many requests from your network. Retry later or contact your administrator if this is an error.'))
+				}
+			});
 			this._setFieldScopeIcon(field, scope);
 			this._updateVerifyButton(field, scope);
 		},

apps/settings/js/settings/personalInfo.js

@@ -248,6 +248,8 @@ window.addEventListener('DOMContentLoaded', function () {
 		var selectedLocale = $("#localeinput").val(),
 			user = OC.getCurrentUser();
 
+		var errorMessage = t('settings', 'An error occurred while changing your locale. Please reload the page and try again.')
+
 		$.ajax({
 			url: OC.linkToOCS('cloud/users', 2) + user.uid,
 			method: 'PUT',
@@ -259,8 +261,14 @@ window.addEventListener('DOMContentLoaded', function () {
 				moment.locale(selectedLocale);
 			},
 			fail: function() {
-				OC.Notification.showTemporary(t('settings', 'An error occurred while changing your locale. Please reload the page and try again.'));
-			}
+				OC.Notification.showTemporary(errorMessage);
+			},
+			error: function(xhr) {
+				if (xhr.status === 429) {
+					errorMessage += '\n' + t('settings', 'There were too many requests from your network. Retry later or contact your administrator if this is an error.')
+				}
+				OC.Notification.showTemporary(errorMessage)
+			},
 		});
 	};
 	$("#localeinput").change(updateLocale);