Skip to content

Commit b155adb

Browse files
committed
Fix setting menu height
- Increase max height to match page height - Move settings 8px from the right instead of 5px to match other top menus - Handle overflow of the content correctly Signed-off-by: Carl Schwan <[email protected]>
1 parent 76f42e1 commit b155adb

File tree

5 files changed

+13
-10
lines changed

5 files changed

+13
-10
lines changed

core/css/header.css

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/css/header.css.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/css/header.scss

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262

6363
@mixin header-menu-height() {
6464
min-height: calc(44px * 1.5); // show at least 1.5 entries
65-
max-height: calc(100vh - #{variables.$header-height} * 2);
65+
max-height: calc(100vh - #{variables.$header-height} - 8px);
6666
}
6767

6868
#header {
@@ -78,9 +78,10 @@
7878
position: absolute;
7979
max-width: 350px;
8080
@include header-menu-height();
81-
right: 5px; // relative to parent
81+
right: 8px; // relative to parent
8282
top: variables.$header-height;
8383
margin: 0;
84+
overflow-y: scroll;
8485

8586
&:not(.popovermenu) {
8687
display: none;

core/css/server.css

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)