Skip to content

Commit bb48b4b

Browse files
committed
fix: adapt rename action tests to check for parent permissions
Signed-off-by: Hamza <[email protected]>
1 parent ce15c53 commit bb48b4b

File tree

2 files changed

+22
-9
lines changed

2 files changed

+22
-9
lines changed

apps/files/src/actions/renameAction.spec.ts

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,23 @@
33
* SPDX-License-Identifier: AGPL-3.0-or-later
44
*/
55
import { action } from './renameAction'
6-
import { File, Permission, View, FileAction } from '@nextcloud/files'
6+
import { File, Folder, Permission, View, FileAction } from '@nextcloud/files'
77
import * as eventBus from '@nextcloud/event-bus'
8-
import { describe, expect, test, vi } from 'vitest'
8+
import { describe, expect, test, vi, beforeEach } from 'vitest'
9+
import { useFilesStore } from '../store/files'
10+
import { getPinia } from '../store/index.ts'
911

1012
const view = {
1113
id: 'files',
1214
name: 'Files',
1315
} as View
1416

17+
beforeEach(() => {
18+
const root = new Folder({ owner: 'test', source: 'https://cloud.domain.com/remote.php/dav/files/admin/', id: 1, permissions: Permission.CREATE })
19+
const files = useFilesStore(getPinia())
20+
files.setRoot({ service: 'files', root })
21+
})
22+
1523
describe('Rename action conditions tests', () => {
1624
test('Default values', () => {
1725
expect(action).toBeInstanceOf(FileAction)
@@ -26,7 +34,7 @@ describe('Rename action conditions tests', () => {
2634
describe('Rename action enabled tests', () => {
2735
test('Enabled for node with UPDATE permission', () => {
2836
const file = new File({
29-
id: 1,
37+
id: 2,
3038
source: 'https://cloud.domain.com/remote.php/dav/files/admin/foobar.txt',
3139
owner: 'admin',
3240
mime: 'text/plain',
@@ -39,7 +47,7 @@ describe('Rename action enabled tests', () => {
3947

4048
test('Disabled for node without DELETE permission', () => {
4149
const file = new File({
42-
id: 1,
50+
id: 2,
4351
source: 'https://cloud.domain.com/remote.php/dav/files/admin/foobar.txt',
4452
owner: 'admin',
4553
mime: 'text/plain',
@@ -54,13 +62,13 @@ describe('Rename action enabled tests', () => {
5462
window.OCA = { Files: { Sidebar: {} } }
5563

5664
const file1 = new File({
57-
id: 1,
65+
id: 2,
5866
source: 'https://cloud.domain.com/remote.php/dav/files/admin/foo.txt',
5967
owner: 'admin',
6068
mime: 'text/plain',
6169
})
6270
const file2 = new File({
63-
id: 1,
71+
id: 2,
6472
source: 'https://cloud.domain.com/remote.php/dav/files/admin/bar.txt',
6573
owner: 'admin',
6674
mime: 'text/plain',
@@ -76,7 +84,7 @@ describe('Rename action exec tests', () => {
7684
vi.spyOn(eventBus, 'emit')
7785

7886
const file = new File({
79-
id: 1,
87+
id: 2,
8088
source: 'https://cloud.domain.com/remote.php/dav/files/admin/foobar.txt',
8189
owner: 'admin',
8290
mime: 'text/plain',

apps/files/src/services/HotKeysService.spec.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@
33
* SPDX-License-Identifier: AGPL-3.0-or-later
44
*/
55
import { describe, it, vi, expect, beforeEach, beforeAll, afterEach } from 'vitest'
6-
import { File, Permission, View } from '@nextcloud/files'
6+
import { File, Folder, Permission, View } from '@nextcloud/files'
77
import axios from '@nextcloud/axios'
88

99
import { getPinia } from '../store/index.ts'
1010
import { useActiveStore } from '../store/active.ts'
11+
import { useFilesStore } from '../store/files'
1112

1213
import { action as deleteAction } from '../actions/deleteAction.ts'
1314
import { action as favoriteAction } from '../actions/favoriteAction.ts'
@@ -49,13 +50,17 @@ describe('HotKeysService testing', () => {
4950

5051
// Make sure the file is reset before each test
5152
file = new File({
52-
id: 1,
53+
id: 2,
5354
source: 'https://cloud.domain.com/remote.php/dav/files/admin/foobar.txt',
5455
owner: 'admin',
5556
mime: 'text/plain',
5657
permissions: Permission.ALL,
5758
})
5859

60+
const root = new Folder({ owner: 'test', source: 'https://cloud.domain.com/remote.php/dav/files/admin/', id: 1, permissions: Permission.CREATE })
61+
const files = useFilesStore(getPinia())
62+
files.setRoot({ service: 'files', root })
63+
5964
// Setting the view first as it reset the active node
6065
activeStore.onChangedView(view)
6166
activeStore.setActiveNode(file)

0 commit comments

Comments
 (0)