fix for transferring ownership of groupfolders

vanpertsch · vanpertsch · commit c714c3380af9 · 2022-05-10T16:54:22.000+02:00
Signed-off-by: Vanessa Pertsch &lt;vanessa.pertsch@nextcloud.com&gt;
diff --git a/apps/files/lib/Controller/TransferOwnershipController.php b/apps/files/lib/Controller/TransferOwnershipController.php
@@ -30,6 +30,7 @@
 use OCA\Files\BackgroundJob\TransferOwnership;
 use OCA\Files\Db\TransferOwnership as TransferOwnershipEntity;
 use OCA\Files\Db\TransferOwnershipMapper;
+use OCP\Files\IHomeStorage;
 use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\DataResponse;
@@ -97,7 +98,7 @@ public function transfer(string $recipient, string $path): DataResponse {
 			return new DataResponse([], Http::STATUS_BAD_REQUEST);
 		}
 
-		if ($node->getOwner()->getUID() !== $this->userId) {
+		if ($node->getOwner()->getUID() !== $this->userId || !$node->getStorage()->instanceOfStorage(IHomeStorage::class)) {
 			return new DataResponse([], Http::STATUS_FORBIDDEN);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@`
`30`	`30`	`use OCA\Files\BackgroundJob\TransferOwnership;`
`31`	`31`	`use OCA\Files\Db\TransferOwnership as TransferOwnershipEntity;`
`32`	`32`	`use OCA\Files\Db\TransferOwnershipMapper;`
	`33`	`+use OCP\Files\IHomeStorage;`
`33`	`34`	`use OCP\AppFramework\Db\DoesNotExistException;`
`34`	`35`	`use OCP\AppFramework\Http;`
`35`	`36`	`use OCP\AppFramework\Http\DataResponse;`
`@@ -97,7 +98,7 @@ public function transfer(string $recipient, string $path): DataResponse {`
`97`	`98`	`return new DataResponse([], Http::STATUS_BAD_REQUEST);`
`98`	`99`	`}`
`99`	`100`
`100`		`- if ($node->getOwner()->getUID() !== $this->userId) {`
	`101`	`+ if ($node->getOwner()->getUID() !== $this->userId \|\| !$node->getStorage()->instanceOfStorage(IHomeStorage::class)) {`
`101`	`102`	`return new DataResponse([], Http::STATUS_FORBIDDEN);`
`102`	`103`	`}`
`103`	`104`