Skip to content

Commit cba61e9

Browse files
Fix missing label and accessibility of Search function
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
1 parent b7da9ef commit cba61e9

File tree

4 files changed

+19
-14
lines changed

4 files changed

+19
-14
lines changed

core/js/dist/unified-search.js

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/js/dist/unified-search.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/src/components/HeaderMenu.vue

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,14 @@
2727
class="header-menu">
2828
<a class="header-menu__trigger"
2929
href="#"
30+
:aria-label="ariaLabel"
3031
:aria-controls="`header-menu-${id}`"
3132
:aria-expanded="opened"
32-
aria-haspopup="true"
33+
aria-haspopup="menu"
3334
@click.prevent="toggleMenu">
3435
<slot name="trigger" />
3536
</a>
36-
<div v-if="opened"
37+
<div v-show="opened"
3738
:id="`header-menu-${id}`"
3839
class="header-menu__wrapper"
3940
role="menu">
@@ -65,6 +66,10 @@ export default {
6566
type: String,
6667
required: true,
6768
},
69+
ariaLabel: {
70+
type: String,
71+
default: '',
72+
},
6873
open: {
6974
type: Boolean,
7075
default: false,

core/src/views/UnifiedSearch.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@
2424
class="unified-search"
2525
exclude-click-outside-classes="popover"
2626
:open.sync="open"
27+
:aria-label="ariaLabel"
2728
@open="onOpen"
2829
@close="onClose">
2930
<!-- Header icon -->
3031
<template #trigger>
3132
<Magnify class="unified-search__trigger"
3233
:size="20"
33-
:title="ariaLabel"
3434
fill-color="var(--color-primary-text)" />
3535
</template>
3636

0 commit comments

Comments
 (0)