fix(ocm): ignore cache if not setup

ArtificialOwl · ArtificialOwl · commit da7c2c8afdbe · 2025-10-01T07:43:11.000-01:00
Signed-off-by: Maxence Lange &lt;maxence@artificial-owl.com&gt;
diff --git a/lib/private/OCM/OCMDiscoveryService.php b/lib/private/OCM/OCMDiscoveryService.php
@@ -83,9 +83,11 @@ public function discover(string $remote, bool $skipCache = false): IOCMProvider
 					throw new OCMProviderException('Previous discovery failed.');
 				}
 
-				$provider->import(json_decode($cached ?? '', true, 8, JSON_THROW_ON_ERROR) ?? []);
-				$this->remoteProviders[$remote] = $provider;
-				return $provider;
+				if ($cached !== null) {
+					$provider->import(json_decode($cached, true, 8, JSON_THROW_ON_ERROR) ?? []);
+					$this->remoteProviders[$remote] = $provider;
+					return $provider;
+				}
 			} catch (JsonException|OCMProviderException $e) {
 				$this->logger->warning('cache issue on ocm discovery', ['exception' => $e]);
 			}

Original file line number	Diff line number	Diff line change
`@@ -83,9 +83,11 @@ public function discover(string $remote, bool $skipCache = false): IOCMProvider`
`83`	`83`	`throw new OCMProviderException('Previous discovery failed.');`
`84`	`84`	`}`
`85`	`85`
`86`		`- $provider->import(json_decode($cached ?? '', true, 8, JSON_THROW_ON_ERROR) ?? []);`
`87`		`- $this->remoteProviders[$remote] = $provider;`
`88`		`- return $provider;`
	`86`	`+ if ($cached !== null) {`
	`87`	`+ $provider->import(json_decode($cached, true, 8, JSON_THROW_ON_ERROR) ?? []);`
	`88`	`+ $this->remoteProviders[$remote] = $provider;`
	`89`	`+ return $provider;`
	`90`	`+ }`
`89`	`91`	`} catch (JsonException\|OCMProviderException $e) {`
`90`	`92`	`$this->logger->warning('cache issue on ocm discovery', ['exception' => $e]);`
`91`	`93`	`}`