Skip to content

Commit f2d7d13

Browse files
authored
Merge pull request #34335 from nextcloud/backport/34321/stable25
[stable25] Fix invisible status
2 parents 4dea095 + 885b55b commit f2d7d13

File tree

8 files changed

+24
-12
lines changed

8 files changed

+24
-12
lines changed

apps/user_status/css/user-status-menu.css

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/user_status/css/user-status-menu.css.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/user_status/css/user-status-menu.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
background-image: url('../img/user-status-dnd.svg');
3939
}
4040

41-
// TODO: debug why icon-black-white does not work here
4241
.icon-user-status-invisible {
43-
@include icon-color('user-status-invisible', 'user_status', variables.$color-black, 1);
42+
background-image: url('../img/user-status-invisible.svg');
43+
filter: var(--background-invert-if-dark);
4444
}

apps/user_status/src/components/OnlineStatusSelect.vue

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,9 @@
2727
type="radio"
2828
name="user-status-online"
2929
@change="onChange">
30-
<label :for="id" :class="icon" class="user-status-online-select__label">
30+
<label :for="id" class="user-status-online-select__label">
3131
{{ label }}
32+
<span :class="icon" role="img" />
3233
<em class="user-status-online-select__subline">{{ subline }}</em>
3334
</label>
3435
</div>
@@ -76,6 +77,7 @@ export default {
7677
</script>
7778

7879
<style lang="scss" scoped>
80+
@use 'sass:math';
7981
$icon-size: 24px;
8082
$label-padding: 8px;
8183
@@ -91,6 +93,7 @@ $label-padding: 8px;
9193
}
9294
9395
&__label {
96+
position: relative;
9497
display: block;
9598
margin: $label-padding;
9699
padding: $label-padding;
@@ -105,6 +108,15 @@ $label-padding: 8px;
105108
& {
106109
cursor: pointer;
107110
}
111+
112+
span {
113+
position: absolute;
114+
top: calc(50% - math.div($icon-size, 2));
115+
left: $label-padding;
116+
display: block;
117+
width: $icon-size;
118+
height: $icon-size;
119+
}
108120
}
109121
110122
&__input:checked + &__label,

dist/user-status-modal-8299.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/user-status-modal-8299.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/user_status-menu.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/user_status-menu.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)