fix user folder init

Signed-off-by: Robin Appelman <[email protected]>

Author: icewind1991

lib/private/Files/Config/UserMountCache.php

@@ -93,7 +93,7 @@ public function registerMounts(IUser $user, array $mounts, array $mountProviderC
 		if (is_array($mountProviderClasses)) {
 			$cachedMounts = array_filter($cachedMounts, function (ICachedMountInfo $mountInfo) use (
 				$mountProviderClasses
-			) {
+			): bool {
 				return in_array($mountInfo->getMountProvider(), $mountProviderClasses);
 			});
 		}
@@ -131,7 +131,7 @@ public function registerMounts(IUser $user, array $mounts, array $mountProviderC
 			$this->removeFromCache($mount);
 			foreach ($mountsForUsers as $index => $mountForUser) {
 				/** @var ICachedMountInfo $mountForUser */
-				if ($mount->getRootId() == $mountForUser->getRootId() && $mount->getMountPoint() == $mountForUser->getMountPoint()) {
+				if ($mount->getRootId() === $mountForUser->getRootId() && $mount->getMountPoint() === $mountForUser->getMountPoint()) {
 					unset($mountsForUsers[$index]);
 					break;
 				}

lib/private/Files/ObjectStore/ObjectStoreStorage.php

@@ -75,9 +75,13 @@ public function __construct($params) {
 		if (isset($params['objectPrefix'])) {
 			$this->objectPrefix = $params['objectPrefix'];
 		}
-		//initialize cache with root directory in cache
-		if (!$this->is_dir('/')) {
-			$this->mkdir('/');
+
+		// home storage is setup in the SetupManager
+		if (!$this instanceof HomeObjectStoreStorage) {
+			//initialize cache with root directory in cache
+			if (!$this->is_dir('/')) {
+				$this->mkdir('/');
+			}
 		}
 
 		$this->logger = \OC::$server->getLogger();

lib/private/Files/SetupManager.php

@@ -254,8 +254,10 @@ private function oneTimeUserSetup(IUser $user) {
 			$this->mountManager->addMount($homeMount);
 
 			if ($homeMount->getStorageRootId() === -1) {
-				$homeMount->getStorage()->mkdir('');
-				$homeMount->getStorage()->getScanner()->scan('');
+				$homeStorage = $homeMount->getStorage();
+				$homeStorage->mkdir('');
+				$homeStorage->mkdir('files');
+				$homeStorage->getScanner()->scan('');
 			}
 
 			$provider = $homeMount->getMountProvider();