Merge pull request #39689 from nextcloud/bugfix/39135/remove-share-notifications-for-deleted-nodes

fix(notifications): Remove share notification when the node is deleted

Author: nickvergessen

apps/files_sharing/lib/Notification/Notifier.php

@@ -29,6 +29,7 @@
 namespace OCA\Files_Sharing\Notification;
 
 use OCP\Files\IRootFolder;
+use OCP\Files\NotFoundException;
 use OCP\IGroupManager;
 use OCP\IL10N;
 use OCP\IURLGenerator;
@@ -117,6 +118,13 @@ public function prepare(INotification $notification, string $languageCode): INot
 			throw new AlreadyProcessedException();
 		}
 
+		try {
+			$share->getNode();
+		} catch (NotFoundException $e) {
+			// Node is already deleted, so discard the notification
+			throw new AlreadyProcessedException();
+		}
+
 		if ($notification->getSubject() === 'expiresTomorrow') {
 			$notification = $this->parseShareExpiration($share, $notification, $l);
 		} else {