Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nextcloud/server
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0a9c37ad45a8449bacaaf2278d31b5e38ce9a622
Choose a base ref
...
head repository: nextcloud/server
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 01ec6d047f693fa5d26f40001f5bf7e079770828
Choose a head ref
  • 12 commits
  • 11 files changed
  • 1 contributor

Commits on Dec 6, 2024

  1. Revert "[DROP] Recompile for files_sharing changes" 

    This reverts commit a9507ea.
    @thlehmann-ionos
    thlehmann-ionos committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    b4f6b1d View commit details
    Browse the repository at this point in the history

  2. Revert "[POC] [WIP] refactor(files_sharing): move getSuggestions(), g… 

    …etRecommendations() out"

The attempted refactoring helped understanding the dependencies, but is
partly the wrong direction.

The formatter functions should be moved out, the recommendations and
suggestion functions however,  ould need to be differentiated in too
many details that duplicating small aspects of code would be better
than having too many conditions.

This reverts commit 642d623.
    @thlehmann-ionos
    thlehmann-ionos committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    c17261e View commit details
    Browse the repository at this point in the history

  3. AMEND TO: 'refactor(files_sharing): dissolve component SharingEntryLi… 

    …nk into SharingTab' -- Fix broken dissolve
    @thlehmann-ionos
    thlehmann-ionos committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    818af87 View commit details
    Browse the repository at this point in the history

  4. chore(files_sharing): fix inconsistent trim() of shareWith 

    shareWith is below used _trimmed_ to index the field of the
shareWith-to-type mapping; thus, create the key trimmed too.

Why trimming is done here is questionable though.

Refs: #48925

Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
    @thlehmann-ionos
    thlehmann-ionos committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    e623446 View commit details
    Browse the repository at this point in the history

  5. chore(files_sharing): replace reduce() by flat() 

    flat() is speaking

Support is good: https://caniuse.com/array-flat

Refs: #48925

Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
    @thlehmann-ionos
    thlehmann-ionos committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    4ac858c View commit details
    Browse the repository at this point in the history

  6. refactor(files_sharing): add ShareTypes module 

    Encapsulate the share type differntiation/grouping in one module.

Refs: #48925

Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
    @thlehmann-ionos
    thlehmann-ionos committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    ecd31c2 View commit details
    Browse the repository at this point in the history

  7. [WIP] refactor(files_sharing): extract formatForMultiselect() from Sh… 

    …aringInput

Code copied from SharingInput.vue

Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
    @thlehmann-ionos
    thlehmann-ionos committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    0ba6f7b View commit details
    Browse the repository at this point in the history

  8. [WIP] feat(files_sharing): add ExternalShareeSearch 

    Inspired (initially copied) from SearchInput, implemented to search only
for external (remote) sharees.

WIP: changes and further TODOs mentioned in the comments at the
beginning of the file

Refs: #48925

Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
    @thlehmann-ionos
    thlehmann-ionos committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    8d66704 View commit details
    Browse the repository at this point in the history

  9. [WIP] feat(files_sharing): use external sharee search 

    Replace >SearchInput> by <ExternalShareeSearch>, which is implemented
more specifically to search for external sharees

Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
    @thlehmann-ionos
    thlehmann-ionos committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    ac8a857 View commit details
    Browse the repository at this point in the history

  10. [WIP] feat(files_sharing): remove lookup, limit to internal shares 

    Change SharingInput to search for internal share types only.

* Lookup was removed because we don't want to lookup users for
  internal shares
* The global lookup entry is no longer added to the end of the
  list for the same reason
* Share types are limited to internal shares
* Placeholder texts are adapted

Refs: #48925

Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
    @thlehmann-ionos
    thlehmann-ionos committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    0c71e8b View commit details
    Browse the repository at this point in the history

  11. [DROP] Recompile for files_sharing changes

    @thlehmann-ionos
    thlehmann-ionos committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    e42d673 View commit details
    Browse the repository at this point in the history

  12. [WIP] Note: work in progress

    @thlehmann-ionos
    thlehmann-ionos committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    01ec6d0 View commit details
    Browse the repository at this point in the history
Loading