From 2482e8ee3429ebca2baf49c69929983a2c578736 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Wed, 14 Nov 2018 18:04:52 +0100 Subject: [PATCH 1/2] Log invalid settings class Signed-off-by: Robin Appelman --- lib/private/Settings/Manager.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/private/Settings/Manager.php b/lib/private/Settings/Manager.php index 036f1ed594fdc..42ec16e223b72 100644 --- a/lib/private/Settings/Manager.php +++ b/lib/private/Settings/Manager.php @@ -167,7 +167,7 @@ protected function getSettings(string $type, string $section): array { } if (!$setting instanceof ISettings) { - $this->log->logException(new \InvalidArgumentException('Invalid settings setting registered'), ['level' => ILogger::INFO]); + $this->log->logException(new \InvalidArgumentException('Invalid settings setting registered (' . $class . ')'), ['level' => ILogger::INFO]); continue; } From 7ac15d4baba921ae38f22712f16fbec94dd9f705 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Wed, 14 Nov 2018 18:05:13 +0100 Subject: [PATCH 2/2] twofactor auth settings are not regular settings Signed-off-by: Robin Appelman --- apps/twofactor_backupcodes/appinfo/info.xml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/apps/twofactor_backupcodes/appinfo/info.xml b/apps/twofactor_backupcodes/appinfo/info.xml index fd575ec12bbc8..b28f75254b694 100644 --- a/apps/twofactor_backupcodes/appinfo/info.xml +++ b/apps/twofactor_backupcodes/appinfo/info.xml @@ -26,10 +26,6 @@ OCA\TwoFactorBackupCodes\Provider\BackupCodesProvider - - OCA\TwoFactorBackupCodes\Settings\Personal - - OCA\TwoFactorBackupCodes\Activity\Provider