Skip to content

[stable14] Fix user creation using LDAP Plugin #14782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 3 commits into from
Mar 21, 2019
Merged

[stable14] Fix user creation using LDAP Plugin #14782

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f3df76
fix user creation using LDAP Plugin
viniciuscb Mar 1, 2019
dd30daa
Cache cleaning when subadmin adds user to group
viniciuscb Mar 4, 2019
d973398
LDAP plugin: force createUser to return new user's DN
viniciuscb Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cache cleaning when subadmin adds user to group 
This commit fix an error happening when the subadmin tries to create an
user, adding him/her to the group s/he is subadmin of, using a LDAP
User/Group plugin.

This just forces the cache to be reset after an user is added to a
group.

Signed-off-by: Vinicius Cubas Brand <[email protected]>
  • Loading branch information
@viniciuscb
viniciuscb authored and Backportbot committed Mar 21, 2019
commit dd30daa3afcd3c2e8b5fb0183c7a7f8c9dcb0d1b
2 changes: 2 additions & 0 deletions apps/user_ldap/lib/Group_LDAP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,6 +1171,7 @@ public function addToGroup($uid, $gid) {
if ($this->groupPluginManager->implementsActions(GroupInterface::ADD_TO_GROUP)) {
if ($ret = $this->groupPluginManager->addToGroup($uid, $gid)) {
$this->access->connection->clearCache();
unset($this->cachedGroupMembers[$gid]);
}
return $ret;
}
Expand All @@ -1188,6 +1189,7 @@ public function removeFromGroup($uid, $gid) {
if ($this->groupPluginManager->implementsActions(GroupInterface::REMOVE_FROM_GROUP)) {
if ($ret = $this->groupPluginManager->removeFromGroup($uid, $gid)) {
$this->access->connection->clearCache();
unset($this->cachedGroupMembers[$gid]);
}
return $ret;
}
Expand Down