Skip to content

[stable19] Do not emit UserCreatedEvent twice #23931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 2 commits into from
Nov 6, 2020
Merged

[stable19] Do not emit UserCreatedEvent twice #23931

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed46c5c
fix: no more translation from postCreateUser hook to UserCreatedEvent…
Nov 4, 2020
dff1023
fix: also remove use statement of UserCreatedEvent
Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: no more translation from postCreateUser hook to UserCreatedEvent… 
… anymore, as event is already emitted in user manager

Signed-off-by: Tobias Assmann <[email protected]>
  • Loading branch information
@backportbot
Tobias Assmann authored and backportbot[bot] committed Nov 6, 2020
commit ed46c5c94aba3573622982d3f93455b741e25519
4 changes: 0 additions & 4 deletions lib/private/Server.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,10 +508,6 @@ public function __construct($webRoot, \OC\Config $config) {
$userSession->listen('\OC\User', 'postCreateUser', function ($user, $password) {
/** @var $user \OC\User\User */
\OC_Hook::emit('OC_User', 'post_createUser', ['uid' => $user->getUID(), 'password' => $password]);

/** @var IEventDispatcher $dispatcher */
$dispatcher = $this->query(IEventDispatcher::class);
$dispatcher->dispatchTyped(new UserCreatedEvent($user, $password));
});
$userSession->listen('\OC\User', 'preDelete', function ($user) use ($legacyDispatcher) {
/** @var $user \OC\User\User */
Expand Down