From 22ebbba8e663fd549939cf050b515178348e9823 Mon Sep 17 00:00:00 2001 From: Christoph Wurst Date: Fri, 10 Dec 2021 11:35:36 +0100 Subject: [PATCH] Fix setting up 2FA when no providers are set up but backup codes 2FA set up is allowed when only backup codes are set up but no other provider and no provider is failing. This patch syncs up the login controller check with the challenge controller check 10 lines above. Signed-off-by: Christoph Wurst --- core/Middleware/TwoFactorMiddleware.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/Middleware/TwoFactorMiddleware.php b/core/Middleware/TwoFactorMiddleware.php index a6c8a131cee33..795b9b56a9e1a 100644 --- a/core/Middleware/TwoFactorMiddleware.php +++ b/core/Middleware/TwoFactorMiddleware.php @@ -110,7 +110,7 @@ public function beforeController($controller, $methodName) { && $this->twoFactorManager->needsSecondFactor($this->userSession->getUser())) { $providers = $this->twoFactorManager->getProviderSet($this->userSession->getUser()); - if ($providers->getProviders() === [] && !$providers->isProviderMissing()) { + if ($providers->getPrimaryProviders() === [] && !$providers->isProviderMissing()) { return; } }