From 855ef21883abf72702f5da3b5c60143a6e95a338 Mon Sep 17 00:00:00 2001 From: Daniel Kesselberg Date: Sat, 3 Sep 2022 15:28:23 +0200 Subject: [PATCH 1/2] Update docblock for cacheFor Signed-off-by: Daniel Kesselberg --- lib/public/AppFramework/Http/Response.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/public/AppFramework/Http/Response.php b/lib/public/AppFramework/Http/Response.php index 6febef838cf8b..27dc2ee0332b6 100644 --- a/lib/public/AppFramework/Http/Response.php +++ b/lib/public/AppFramework/Http/Response.php @@ -105,8 +105,10 @@ public function __construct() { /** * Caches the response - * @param int $cacheSeconds the amount of seconds that should be cached - * if 0 then caching will be disabled + * + * @param int $cacheSeconds amount of seconds the response is fresh, 0 to disable cache. + * @param bool $public + * @param bool $immutable * @return $this * @since 6.0.0 - return value was added in 7.0.0 */ From c55ae98a3fd504e0e6bf3f161e428a896bb0638f Mon Sep 17 00:00:00 2001 From: Daniel Date: Sat, 3 Sep 2022 15:58:18 +0200 Subject: [PATCH 2/2] Add description for public and immutable Co-authored-by: Carl Schwan Signed-off-by: Daniel --- lib/public/AppFramework/Http/Response.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/public/AppFramework/Http/Response.php b/lib/public/AppFramework/Http/Response.php index 27dc2ee0332b6..9dd84a1664947 100644 --- a/lib/public/AppFramework/Http/Response.php +++ b/lib/public/AppFramework/Http/Response.php @@ -107,8 +107,8 @@ public function __construct() { * Caches the response * * @param int $cacheSeconds amount of seconds the response is fresh, 0 to disable cache. - * @param bool $public - * @param bool $immutable + * @param bool $public whether the page should be cached by public proxy. Usually should be false, unless this is a static resources. + * @param bool $immutable whether browser should treat the resource as immutable and not ask the server for each page load if the resource changed. * @return $this * @since 6.0.0 - return value was added in 7.0.0 */