diff --git a/build/psalm-baseline.xml b/build/psalm-baseline.xml index 8a2c728ab5b4b..273c7ef470946 100644 --- a/build/psalm-baseline.xml +++ b/build/psalm-baseline.xml @@ -3075,14 +3075,7 @@ $maxPreviewImage - $semId - - $sem - - - false|resource - null|string diff --git a/lib/private/Preview/Generator.php b/lib/private/Preview/Generator.php index 4a1270fa4a60b..958f58e2a0179 100644 --- a/lib/private/Preview/Generator.php +++ b/lib/private/Preview/Generator.php @@ -221,7 +221,7 @@ public function generatePreviews(File $file, array $specifications, $mimeType = * * @param int $semId * @param int $concurrency - * @return false|resource the semaphore on success or false on failure + * @return false|\SysvSemaphore the semaphore on success or false on failure */ public static function guardWithSemaphore(int $semId, int $concurrency) { if (!extension_loaded('sysvsem')) { @@ -240,11 +240,11 @@ public static function guardWithSemaphore(int $semId, int $concurrency) { /** * Releases the semaphore acquired from {@see Generator::guardWithSemaphore()}. * - * @param resource|bool $semId the semaphore identifier returned by guardWithSemaphore + * @param false|\SysvSemaphore $semId the semaphore identifier returned by guardWithSemaphore * @return bool */ - public static function unguardWithSemaphore($semId): bool { - if (!is_resource($semId) || !extension_loaded('sysvsem')) { + public static function unguardWithSemaphore(false|\SysvSemaphore $semId): bool { + if ($semId === false || !($semId instanceof \SysvSemaphore)) { return false; } return sem_release($semId);