From 8ee070cce5491a8f6a93354f0239d9747c2635ed Mon Sep 17 00:00:00 2001 From: Josh Date: Mon, 27 May 2024 09:19:48 -0400 Subject: [PATCH] fix(cron): Log excess memory usage at debug and info levels Signed-off-by: Josh --- cron.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cron.php b/cron.php index 8cd97258003fa..c51cf91b17462 100644 --- a/cron.php +++ b/cron.php @@ -163,10 +163,10 @@ $memoryAfter = memory_get_usage(); $memoryPeakAfter = memory_get_peak_usage(); - if ($memoryAfter - $memoryBefore > 10_000_000) { - $logger->warning('Used memory grew by more than 10 MB when executing job ' . $jobDetails . ': ' . Util::humanFileSize($memoryAfter). ' (before: ' . Util::humanFileSize($memoryBefore) . ')', ['app' => 'cron']); + if ($memoryAfter - $memoryBefore > 50_000_000) { + $logger->warning('Used memory grew by more than 50 MB when executing job ' . $jobDetails . ': ' . Util::humanFileSize($memoryAfter). ' (before: ' . Util::humanFileSize($memoryBefore) . ')', ['app' => 'cron']); } - if ($memoryPeakAfter > 300_000_000) { + if ($memoryPeakAfter > 300_000_000 && $memoryPeakBefore <= 300_000_000) { $logger->warning('Cron job used more than 300 MB of ram after executing job ' . $jobDetails . ': ' . Util::humanFileSize($memoryPeakAfter) . ' (before: ' . Util::humanFileSize($memoryPeakBefore) . ')', ['app' => 'cron']); }