From 676dca4116f2f04684a46a26fd1e8071bdd40a71 Mon Sep 17 00:00:00 2001
From: Josh Richards <josh.t.richards@gmail.com>
Date: Sat, 6 Jul 2024 18:01:25 -0400
Subject: [PATCH] fix(previews): Stop returning true when getimagesize() fails

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
---
 lib/private/legacy/OC_Image.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/private/legacy/OC_Image.php b/lib/private/legacy/OC_Image.php
index c7e278c985f97..998bf09bf0eb3 100644
--- a/lib/private/legacy/OC_Image.php
+++ b/lib/private/legacy/OC_Image.php
@@ -626,7 +626,7 @@ private function checkImageMemory($width, $height) {
 	private function checkImageSize($path) {
 		$size = @getimagesize($path);
 		if (!$size) {
-			return true;
+			return false;
 		}
 
 		$width = $size[0];
@@ -647,7 +647,7 @@ private function checkImageSize($path) {
 	private function checkImageDataSize($data) {
 		$size = @getimagesizefromstring($data);
 		if (!$size) {
-			return true;
+			return false;
 		}
 
 		$width = $size[0];
@@ -694,7 +694,7 @@ public function loadFromFile($imagePath = false) {
 					if (!$this->checkImageSize($imagePath)) {
 						return false;
 					}
-					if (getimagesize($imagePath) !== false) {
+					if (@getimagesize($imagePath) !== false) {
 						$this->resource = @imagecreatefromjpeg($imagePath);
 					} else {
 						$this->logger->debug('OC_Image->loadFromFile, JPG image not valid: ' . $imagePath, ['app' => 'core']);