From 0628eb62f3724bf84f5506f1df5e1a32f76754a4 Mon Sep 17 00:00:00 2001 From: SebastianKrupinski Date: Thu, 12 Dec 2024 23:06:01 -0500 Subject: [PATCH] fix: return 204 instead of 404 Signed-off-by: SebastianKrupinski --- apps/dav/lib/CardDAV/ImageExportPlugin.php | 2 +- apps/dav/tests/unit/CardDAV/ImageExportPluginTest.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/dav/lib/CardDAV/ImageExportPlugin.php b/apps/dav/lib/CardDAV/ImageExportPlugin.php index e9d390d0849d9..8a950202c08fd 100644 --- a/apps/dav/lib/CardDAV/ImageExportPlugin.php +++ b/apps/dav/lib/CardDAV/ImageExportPlugin.php @@ -90,7 +90,7 @@ public function httpGet(RequestInterface $request, ResponseInterface $response) $response->setBody($file->getContent()); } catch (NotFoundException $e) { - $response->setStatus(404); + $response->setStatus(\OCP\AppFramework\Http::STATUS_NO_CONTENT); } return false; diff --git a/apps/dav/tests/unit/CardDAV/ImageExportPluginTest.php b/apps/dav/tests/unit/CardDAV/ImageExportPluginTest.php index 6718153f91041..cf6ddb1ff7b5a 100644 --- a/apps/dav/tests/unit/CardDAV/ImageExportPluginTest.php +++ b/apps/dav/tests/unit/CardDAV/ImageExportPluginTest.php @@ -171,7 +171,7 @@ public function testCard($size, $photo): void { ->willThrowException(new NotFoundException()); $this->response->expects($this->once()) ->method('setStatus') - ->with(404); + ->with(\OCP\AppFramework\Http::STATUS_NO_CONTENT); } $result = $this->plugin->httpGet($this->request, $this->response);